Issue 7665045: code review 7665045: go.crypto/sha3: fix typo; remove 4 million map lookups ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7665045: code review 7665045: go.crypto/sha3: fix typo; remove 4 million map lookups ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by nigeltao

Modified:
11 years ago

Reviewers:

CC:
jcb, agl1, golang-dev

Visibility:
Public.

Description

go.crypto/sha3: fix typo; remove 4 million map lookups (5% of "go test" time); delete some comments that didn't add much and were incorrect anyway (the test specification was tc, not t).

Patch Set 1 #

Patch Set 2 : diff -r dacdc6831675 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r dacdc6831675 https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r dacdc6831675 https://code.google.com/p/go.crypto #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
	M	sha3/sha3_test.go	View	1	2 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello jcb@google.com (cc: agl@golang.org, golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto

11 years ago (2013-03-22 22:51:40 UTC) #1

nigeltao

11 years ago (2013-03-22 23:10:42 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=4b83cf024724&repo=crypto ***

go.crypto/sha3: fix typo; remove 4 million map lookups (5% of "go test"
time); delete some comments that didn't add much and were incorrect
anyway (the test specification was tc, not t).

R=jcb
CC=agl, golang-dev
https://codereview.appspot.com/7665045

Expand All Messages | Collapse All Messages