code review 7664044: cgo: enable external linking mode on FreeBSD amd64.

cgo: enable external linking mode on FreeBSD amd64.

Tested on FreeBSD 9.1 amd64, per rsc's instructions at
https://groups.google.com/d/topic/golang-dev/HjRTLvRsJXo/discussion .

[mccoyst, 2013-03-09 06:30:55]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[mccoyst, 2013-03-09 13:36:46]

PTAL. Inspired by Lucio's OpenBSD CL, I've grouped the Hfreebsd case with the
Hlinux case in the switch.

[lucio, 2013-03-09 13:53:16]

Thank you for the show of faith, but I thought I was just following
Russ' instructions :-)

Lucio.


On 3/9/13, MccoyST@gmail.com <MccoyST@gmail.com> wrote:
> PTAL. Inspired by Lucio's OpenBSD CL, I've grouped the Hfreebsd case
> with the Hlinux case in the switch.
>
> https://codereview.appspot.com/7664044/
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>

[dho, 2013-03-09 15:19:08]

NOT LGTM. This deadlocks for me on FreeBSD 9-STABLE. It's not a very
recent 9-STABLE, but would rather understand whether this is going to
work on FreeBSD 8, 9, and HEAD before it goes in.

[rsc, 2013-03-09 22:51:29]

LGTM

Putting it in doesn't mean it will be used. I'm going to submit it and then
it's easier to debug. Worst case we have to tell people to use FreeBSD 9.1.

[rsc, 2013-03-09 22:51:59]

*** Submitted as https://code.google.com/p/go/source/detail?r=29ec985b2d7b ***

cgo: enable external linking mode on FreeBSD amd64.

Tested on FreeBSD 9.1 amd64, per rsc's instructions at
https://groups.google.com/d/topic/golang-dev/HjRTLvRsJXo/discussion .

R=golang-dev, lucio.dere, devon.odell, rsc
CC=golang-dev
https://codereview.appspot.com/7664044

Committer: Russ Cox <rsc@golang.org>

[remyoudompheng, 2013-07-21 19:53:16]

R=close