Issue 7663048: state: hook up StateWatcher to allWatcher

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7663048: state: hook up StateWatcher to allWatcher

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by rog

Modified:
11 years, 1 month ago

Reviewers:
dimitern, mp+154103, fwereade

Visibility:
Public.

Description

state: hook up StateWatcher to allWatcher You never know, the GUI might start working now. https://code.launchpad.net/~rogpeppe/juju-core/246-allwatcher-integrate/+merge/154103 Requires: https://code.launchpad.net/~rogpeppe/juju-core/245-allwatcher-state-backing/+merge/153900 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: hook up StateWatcher to allWatcher #

Total comments: 3

Patch Set 3 : state: hook up StateWatcher to allWatcher #

Patch Set 4 : state: hook up StateWatcher to allWatcher #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -80 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/apiserver/api_test.go	View	1 2 3	2 chunks	+12 lines, -5 lines	0 comments	Download
M	state/megawatcher.go	View	1 2	7 chunks	+15 lines, -49 lines	0 comments	Download
M	state/megawatcher_internal_test.go	View	1 2	21 chunks	+25 lines, -25 lines	0 comments	Download
M	state/open.go	View	1 2 3	2 chunks	+4 lines, -1 line	0 comments	Download
M	state/state.go	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dimitern

LGTM, nice to see everything come together finally. https://codereview.appspot.com/7663048/diff/2001/state/megawatcher.go File state/megawatcher.go (right): https://codereview.appspot.com/7663048/diff/2001/state/megawatcher.go#newcode16 state/megawatcher.go:16: // ...

11 years, 1 month ago (2013-03-19 14:47:50 UTC) #2

fwereade

LGTM https://codereview.appspot.com/7663048/diff/2001/state/apiserver/api_test.go File state/apiserver/api_test.go (right): https://codereview.appspot.com/7663048/diff/2001/state/apiserver/api_test.go#newcode1321 state/apiserver/api_test.go:1321: // all the logic is tested elsewhere. I'm ...

11 years, 1 month ago (2013-03-20 13:26:48 UTC) #3

rog

11 years, 1 month ago (2013-03-20 16:47:49 UTC) #4

*** Submitted:

state: hook up StateWatcher to allWatcher

You never know, the GUI might start working now.

R=dimitern, fwereade
CC=
https://codereview.appspot.com/7663048

https://codereview.appspot.com/7663048/diff/2001/state/apiserver/api_test.go
File state/apiserver/api_test.go (right):

https://codereview.appspot.com/7663048/diff/2001/state/apiserver/api_test.go#...
state/apiserver/api_test.go:1321: // all the logic is tested elsewhere.
On 2013/03/20 13:26:48, fwereade wrote:
> I'm a bit uncomfortable about the lightness of this test in particular, but I
> think I may be being overly paranoid.

i did think quite hard about doing a more comprehensive test here, but i
couldn't decide what extra logic i'd actually be testing. the api client really
is just a trivial extension (via the network) of exactly the same operations
provided by state.StateWatcher AFAICS. if you can think of any test coverage
that i'm missing, i'd be very glad to know of it.

Expand All Messages | Collapse All Messages