code review 76610045: encoding/base64: Refactor encoder.Write.

base64: refactor encoder.Write

"nn" can never be zero for any input "p", so no check is needed.
This change should improve readability a bit.

[ruiu, 2014-03-17 05:59:01]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2014-03-17 19:02:58]

R=nigeltao



On Sun, Mar 16, 2014 at 10:59 PM, <ruiu@google.com> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> encoding/base64: Refactor encoder.Write.
>
> "nn" can never be zero for any input "p", so no check is needed.
> This change should improve readability a bit.
>
> Please review this at https://codereview.appspot.com/76610045/
>
> Affected files (+4, -6 lines):
>   M src/pkg/encoding/base64/base64.go
>
>
> Index: src/pkg/encoding/base64/base64.go
> ===================================================================
> --- a/src/pkg/encoding/base64/base64.go
> +++ b/src/pkg/encoding/base64/base64.go
> @@ -159,13 +159,11 @@
>                 nn := len(e.out) / 4 * 3
>                 if nn > len(p) {
>                         nn = len(p)
> +                       nn -= nn % 3
>                 }
> -               nn -= nn % 3
> -               if nn > 0 {
> -                       e.enc.Encode(e.out[0:], p[0:nn])
> -                       if _, e.err = e.w.Write(e.out[0 : nn/3*4]); e.err
> != nil {
> -                               return n, e.err
> -                       }
> +               e.enc.Encode(e.out[0:], p[0:nn])
> +               if _, e.err = e.w.Write(e.out[0 : nn/3*4]); e.err != nil {
> +                       return n, e.err
>                 }
>                 n += nn
>                 p = p[nn:]
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[nigeltao, 2014-03-18 05:25:48]

LGTM.

[nigeltao, 2014-03-18 05:26:40]

*** Submitted as https://code.google.com/p/go/source/detail?r=06f148a92fbb ***

base64: refactor encoder.Write

"nn" can never be zero for any input "p", so no check is needed.
This change should improve readability a bit.

LGTM=nigeltao
R=golang-codereviews, bradfitz, nigeltao
CC=golang-codereviews
https://codereview.appspot.com/76610045

Committer: Nigel Tao <nigeltao@golang.org>

[gobot, 2014-03-18 05:31:30]

This CL appears to have broken the netbsd-386-minux builder.
See http://build.golang.org/log/5a6a0f2e9916e9caa2d6b33a82159fd633d0be9d