rename contrib -> scripts

rename contrib -> scripts

Rename contrib to scripts directory to general acclaim. The rename is not obvious in rietveld, please refer to the lp merge proposal for the details of the rename.

Also: include small whitespace fix picked up by gofmt.

https://code.launchpad.net/~dave-cheney/juju-core/103-rename-contrib-scripts/+merge/152519

(do not edit description out of merge proposal)

[dave_cheney.net, 2013-03-08 21:41:10]

Please take a look.

[dimitern, 2013-03-08 21:46:50]

The description does no seem to match the change.
I cannot see what's really changed here except:

https://codereview.appspot.com/7650043/diff/1/cmd/juju/cmd_test.go
File cmd/juju/cmd_test.go (right):

https://codereview.appspot.com/7650043/diff/1/cmd/juju/cmd_test.go#newcode241
cmd/juju/cmd_test.go:241: // bad unit count
this...

[dave_cheney.net, 2013-03-08 21:48:23]

It is a whitespace change. go fmt from Go 1.0 does not detect trailing
whitespace in comments, Go 1.1 (tip) does.

On Sat, Mar 9, 2013 at 8:46 AM,  <dimiter.naydenov@canonical.com> wrote:
> The description does no seem to match the change.
> I cannot see what's really changed here except:
>
>
> https://codereview.appspot.com/7650043/diff/1/cmd/juju/cmd_test.go
> File cmd/juju/cmd_test.go (right):
>
> https://codereview.appspot.com/7650043/diff/1/cmd/juju/cmd_test.go#newcode241
> cmd/juju/cmd_test.go:241: // bad unit count
> this...
>
> https://codereview.appspot.com/7650043/

[dave_cheney.net, 2013-03-08 21:52:23]

Please take a look.

[jameinel, 2013-03-08 21:56:21]

The launchpad description is accurate with:
=== renamed directory 'contrib' => 'scripts'

That doesn't generate a 'bzr diff' of each file being deleted and re-added. I'm
not sure what codereview.appspot.com would want to represent a rename.

LGTM

[thumper, 2013-03-08 22:00:16]

On 2013/03/08 21:56:21, jameinel wrote:
> The launchpad description is accurate with:
> === renamed directory 'contrib' => 'scripts'
> 
> That doesn't generate a 'bzr diff' of each file being deleted and re-added.
I'm
> not sure what http://codereview.appspot.com would want to represent a rename.
> 
> LGTM

LGTM

I like this change

[dave_cheney.net, 2013-03-08 22:03:10]

*** Submitted:

rename contrib -> scripts

Rename contrib to scripts directory to general acclaim. The rename is not
obvious in rietveld, please refer to the lp merge proposal for the details of
the rename.

Also: include small whitespace fix picked up by gofmt.

R=dimitern, jameinel, thumper
CC=
https://codereview.appspot.com/7650043