Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(403)

Issue 7644044: Add the sidebar view into the Browser subapp

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by rharding
Modified:
12 years, 4 months ago
Reviewers:
mp+152485, jeff.pihach
Visibility:
Public.

Description

Add the sidebar view into the Browser subapp - Add the sidebar view - build it into the subapp - Adjust the watches to rebuild on changed .less files https://code.launchpad.net/~rharding/juju-gui/init-sidebar/+merge/152485 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 10

Patch Set 2 : Add the sidebar view into the Browser subapp #

Total comments: 1

Patch Set 3 : Add the sidebar view into the Browser subapp #

Patch Set 4 : Add the sidebar view into the Browser subapp #

Patch Set 5 : Add the sidebar view into the Browser subapp #

Patch Set 6 : Add the sidebar view into the Browser subapp #

Patch Set 7 : Add the sidebar view into the Browser subapp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -35 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/modules-debug.js View 1 chunk +5 lines, -0 lines 0 comments Download
M app/subapps/browser/browser.js View 5 chunks +29 lines, -6 lines 0 comments Download
M app/subapps/browser/templates/fullscreen.handlebars View 1 chunk +1 line, -1 line 0 comments Download
A app/subapps/browser/templates/sidebar.handlebars View 1 chunk +17 lines, -0 lines 0 comments Download
A app/subapps/browser/views/sidebar.js View 1 1 chunk +95 lines, -0 lines 0 comments Download
M config.js View 1 chunk +4 lines, -1 line 0 comments Download
M lib/templates.js View 2 chunks +23 lines, -14 lines 0 comments Download
A lib/views/browser/main.less View 1 chunk +28 lines, -0 lines 0 comments Download
M lib/views/stylesheet.less View 1 1 chunk +4 lines, -0 lines 0 comments Download
M test/test_browser_app.js View 1 2 chunks +78 lines, -13 lines 0 comments Download

Messages

Total messages: 8
rharding
Please take a look.
12 years, 4 months ago (2013-03-08 18:44:08 UTC) #1
j.c.sackett
https://codereview.appspot.com/7644044/diff/1/app/subapps/browser/browser.js File app/subapps/browser/browser.js (right): https://codereview.appspot.com/7644044/diff/1/app/subapps/browser/browser.js#newcode116 app/subapps/browser/browser.js:116: { path: '/bws/sidebar/', callbacks: 'sidebar' } Did we decide ...
12 years, 4 months ago (2013-03-08 19:20:06 UTC) #2
rharding
On 2013/03/08 19:20:06, j.c.sackett wrote: > https://codereview.appspot.com/7644044/diff/1/app/subapps/browser/browser.js > File app/subapps/browser/browser.js (right): > > https://codereview.appspot.com/7644044/diff/1/app/subapps/browser/browser.js#newcode116 > ...
12 years, 4 months ago (2013-03-08 19:35:51 UTC) #3
jeff.pihach
Looks good! Just a few comments below. https://codereview.appspot.com/7644044/diff/1/app/app.js File app/app.js (right): https://codereview.appspot.com/7644044/diff/1/app/app.js#newcode1193 app/app.js:1193: { path: ...
12 years, 4 months ago (2013-03-08 19:40:14 UTC) #4
rharding
On 2013/03/08 19:40:14, jeff.pihach wrote: > https://codereview.appspot.com/7644044/diff/1/app/subapps/browser/templates/sidebar.handlebars#newcode6 > app/subapps/browser/templates/sidebar.handlebars:6: <img height="16px" > width="16px"/>&nbsp;Charm Browser > ...
12 years, 4 months ago (2013-03-08 19:53:55 UTC) #5
rharding
Please take a look.
12 years, 4 months ago (2013-03-08 20:02:07 UTC) #6
jeff.pihach
LGTM https://codereview.appspot.com/7644044/diff/12001/app/subapps/browser/views/sidebar.js File app/subapps/browser/views/sidebar.js (right): https://codereview.appspot.com/7644044/diff/12001/app/subapps/browser/views/sidebar.js#newcode73 app/subapps/browser/views/sidebar.js:73: if (typeof container !== 'object') { Yeah that... ...
12 years, 4 months ago (2013-03-08 20:21:03 UTC) #7
rharding
12 years, 4 months ago (2013-03-08 20:56:15 UTC) #8
*** Submitted:

Add the sidebar view into the Browser subapp

- Add the sidebar view
- build it into the subapp
- Adjust the watches to rebuild on changed .less files

R=j.c.sackett, jeff.pihach
CC=
https://codereview.appspot.com/7644044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b