Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(183)

Issue 7641046: Implement Annotations in go env.

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by matthew.scott
Modified:
12 years, 4 months ago
Reviewers:
mp+152505, gary.poster
Visibility:
Public.

Description

Implement Annotations in go env. Annotations were added in gojuju, this branch implements them in the go environment in the GUI. Additionally, in preparation for the different entity name styles ('mysql' in pyjuju, 'service-mysql' in gojuju), the relevant model lists now have a createDisplayName method that normalizes the names for displayin in the views. https://code.launchpad.net/~makyo/juju-gui/go-annotations-1152627/+merge/152505 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Implement Annotations in go env. #

Patch Set 3 : Implement Annotations in go env. #

Total comments: 1

Patch Set 4 : Implement Annotations in go env. #

Patch Set 5 : Implement Annotations in go env. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+429 lines, -25 lines) Patch
A [revision details] View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M app/models/models.js View 1 2 3 7 chunks +69 lines, -1 line 0 comments Download
M app/store/env/go.js View 1 1 chunk +122 lines, -0 lines 0 comments Download
M app/templates/service-config.handlebars View 1 chunk +1 line, -1 line 0 comments Download
M app/templates/service-constraints.handlebars View 1 chunk +1 line, -1 line 0 comments Download
M app/templates/service-header.partial View 1 chunk +1 line, -1 line 0 comments Download
M app/templates/unit.handlebars View 1 chunk +1 line, -1 line 0 comments Download
M app/views/charm-panel.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M app/views/topology/service.js View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M app/views/unit.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/test_env_go.js View 1 2 chunks +189 lines, -0 lines 0 comments Download
M test/test_environment_view.js View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M test/test_fakebackend.js View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M test/test_model.js View 1 chunk +18 lines, -0 lines 0 comments Download
M test/test_service_module.js View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M test/test_unit_view.js View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7
matthew.scott
Please take a look.
12 years, 4 months ago (2013-03-08 20:18:44 UTC) #1
matthew.scott
Please take a look.
12 years, 4 months ago (2013-03-08 22:11:00 UTC) #2
matthew.scott
Please take a look.
12 years, 4 months ago (2013-03-08 22:22:06 UTC) #3
gary.poster
This is a quick pre-review note to suggest that you generate the displayName in the ...
12 years, 4 months ago (2013-03-08 22:51:33 UTC) #4
matthew.scott
Please take a look.
12 years, 4 months ago (2013-03-11 17:46:26 UTC) #5
gary.poster
LGTM. Nice work & especially nice tests. Thanks! Gary
12 years, 4 months ago (2013-03-11 18:37:46 UTC) #6
matthew.scott
12 years, 4 months ago (2013-03-11 19:29:05 UTC) #7
*** Submitted:

Implement Annotations in go env.

Annotations were added in gojuju, this branch implements them in the go
environment in the GUI.  Additionally, in preparation for the different entity
name styles ('mysql' in pyjuju, 'service-mysql' in gojuju), the relevant model
lists now have a createDisplayName method that normalizes the names for
displayin in the views.

R=gary.poster
CC=
https://codereview.appspot.com/7641046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b