Issue 76370043: code review 76370043: cmd/go: make the default coverage mode -atomic if -race...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 76370043: code review 76370043: cmd/go: make the default coverage mode -atomic if -race... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by r

Modified:
11 years, 2 months ago

Reviewers:
gobot, adg

CC:
golang-codereviews, adg

Visibility:
Public.

cmd/go: make the default coverage mode -atomic if -race is set Fixes issue 7013.

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -3 lines)			Patch
M	src/cmd/go/doc.go	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/cmd/go/test.bash	View	1 chunk	+31 lines, -0 lines	0 comments	Download
M	src/cmd/go/test.go	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/cmd/go/testflag.go	View	2 chunks	+8 lines, -1 line	0 comments	Download

Total messages: 5

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 2 months ago (2014-03-15 04:49:24 UTC) #1

*** Submitted as https://code.google.com/p/go/source/detail?r=c742257f2c9f *** cmd/go: make the default coverage mode -atomic if -race is ...

11 years, 2 months ago (2014-03-18 03:38:13 UTC) #4

gobot

11 years, 2 months ago (2014-03-18 04:29:51 UTC) #5

Message was sent while issue was closed.

This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/a10e09437f54cfe4f1f06732f80be5810a4a32ef