Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(313)

Issue 76320043: code review 76320043: net/http: Request Body error should not be ignored.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by bancek
Modified:
11 years, 2 months ago
Reviewers:
bradfitz
CC:
golang-codereviews, bradfitz
Visibility:
Public.

Description

net/http: Request Body error should not be ignored. Fixes issue 7521.

Patch Set 1 #

Patch Set 2 : diff -r 6960b48414c9 https://code.google.com/p/go #

Patch Set 3 : diff -r b1c5bf74b59e https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -2 lines) Patch
M src/pkg/net/http/requestwrite_test.go View 1 1 chunk +40 lines, -0 lines 0 comments Download
M src/pkg/net/http/transfer.go View 1 2 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 7
bancek
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 2 months ago (2014-03-15 00:12:27 UTC) #1
bradfitz
Have you filed a CLA? I don't see one for your gmail address. If so, ...
11 years, 2 months ago (2014-03-17 21:42:51 UTC) #2
bancek
On 2014/03/17 21:42:51, bradfitz wrote: > Have you filed a CLA? I don't see one ...
11 years, 2 months ago (2014-03-17 21:45:46 UTC) #3
bradfitz
Yes please. I see your other one filed but gmail would make it easier since ...
11 years, 2 months ago (2014-03-17 21:57:56 UTC) #4
bancek
On 2014/03/17 21:57:56, bradfitz wrote: > Yes please. I see your other one filed but ...
11 years, 2 months ago (2014-03-17 22:30:37 UTC) #5
bradfitz
LGTM
11 years, 2 months ago (2014-03-17 22:52:18 UTC) #6
bradfitz
11 years, 2 months ago (2014-03-17 22:53:22 UTC) #7
*** Submitted as https://code.google.com/p/go/source/detail?r=2162d6893121 ***

net/http: Request Body error should not be ignored.

Fixes issue 7521.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/76320043

Committer: Brad Fitzpatrick <bradfitz@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b