code review 7631043: go.talks/present: Fix swiping on Android so it works pa...

go.talks/present: Fix swiping on Android so it works past the third slide.
Used the suggestion found here: http://stackoverflow.com/a/11613327

Fixes issue 5004.

[wathiede, 2013-03-08 06:58:36]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.talks

[adg, 2013-03-11 00:26:39]

R=adg

[adg, 2013-03-11 06:36:26]

This still looks broken on my Nexus 7. How's it supposed to fix it?

[wathiede, 2013-03-11 17:02:20]

On 2013/03/11 06:36:26, adg wrote:
> This still looks broken on my Nexus 7. How's it supposed to fix it?

When I added console.log() calls to handleTouch{Start,Move,End}, I would see
Start, only 2 Moves, and no call to End (I was using chrome remote debugging to
see the logging).  I believe the browser was taking over the subsequent moves
and never calling the End handler.  It is supposed to work by preventing the
default touchmove handler from stealing touch movements.  As a result, I then
see the touchend event fire, which is where slide.js does the actual page
turning.

I've put a copy of this CL up and running at:

http://5004-r1.mygoissues.appspot.com/2012/splash.slide#1

Testing again here on my N7 and Galaxy Nexus against that URL seems to work. 
The swipe functionality here will not move the page as you swipe, only when you
lift your finger will it determine which way you swiped and then move to the
previous/next page accordingly.

Note I've only tested with Chrome, there is no 'Browser' app (with the blue
globe icon) on your N7 right?

If you still don't see it working against the appspot URL, I can try
instrumenting the page to print out touch events, maybe your seeing a different
set of events generated then I am.

[wathiede, 2013-03-11 21:41:18]

On 2013/03/11 17:02:20, wathiede wrote:
> On 2013/03/11 06:36:26, adg wrote:
> > This still looks broken on my Nexus 7. How's it supposed to fix it?
> 
> When I added console.log() calls to handleTouch{Start,Move,End}, I would see
> Start, only 2 Moves, and no call to End (I was using chrome remote debugging
to
> see the logging).  I believe the browser was taking over the subsequent moves
> and never calling the End handler.  It is supposed to work by preventing the
> default touchmove handler from stealing touch movements.  As a result, I then
> see the touchend event fire, which is where slide.js does the actual page
> turning.
> 
> I've put a copy of this CL up and running at:
> 
> http://5004-r1.mygoissues.appspot.com/2012/splash.slide#1
> 
> Testing again here on my N7 and Galaxy Nexus against that URL seems to work. 
> The swipe functionality here will not move the page as you swipe, only when
you
> lift your finger will it determine which way you swiped and then move to the
> previous/next page accordingly.

It's worth noting that this seems to be a slight functional change on iDevices,
at least according to my cursory experimenting with the simulator on my Mac. 
There is now what I would call a snap-to behavior on iDevices.  If we want to be
able to have the old iDevice behavior across touch devices, I would need to add
some sort of manual translation to the viewport or slide deck within the
touchmove handler.
 
 
> Note I've only tested with Chrome, there is no 'Browser' app (with the blue
> globe icon) on your N7 right?
> 
> If you still don't see it working against the appspot URL, I can try
> instrumenting the page to print out touch events, maybe your seeing a
different
> set of events generated then I am.

[adg, 2013-06-24 03:53:32]

LGTM

I finally had a chance to test this under Android and iOS and it at least
improves the situation, if not fixes it.

I think the slide layout code probably needs an overhaul to make it totally
portable, but that's another issue.

[adg, 2013-06-24 03:54:26]

*** Submitted as
https://code.google.com/p/go/source/detail?r=f142c9f666d9&repo=talks ***

go.talks/present: Fix swiping on Android so it works past the third slide.
Used the suggestion found here: http://stackoverflow.com/a/11613327

Fixes issue 5004.

R=adg
CC=golang-dev
https://codereview.appspot.com/7631043

Committer: Andrew Gerrand <adg@golang.org>