Issue 7624043: code review 7624043: cmd/6l, cmd/8l: fix BSD builds

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7624043: code review 7624043: cmd/6l, cmd/8l: fix BSD builds (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by rsc

Modified:
12 years, 9 months ago

Reviewers:

CC:
golang-dev

Visibility:
Public.

Description

cmd/6l, cmd/8l: fix BSD builds Before this CL, running cd misc/cgo/test go test -c readelf --dyn-syms test.test | grep cgoexp turned up many UNDEF symbols corresponding to symbols actually in the binary but marked only cgo_export_static. Only symbols marked cgo_export_dynamic should be listed in this mode. And if the symbol is going to be listed, it should be listed with its actual address instead of UNDEF. The Linux dynamic linker didn't care about the seemingly missing symbols, but the BSD one did. This CL eliminates the symbols from the dyn-syms table.

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -22 lines)			Patch
	M	src/cmd/6l/asm.c	View	1	10 chunks	+12 lines, -12 lines	0 comments	Download
	M	src/cmd/8l/asm.c	View	1	8 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

12 years, 9 months ago (2013-03-08 04:13:51 UTC) #1

rsc

12 years, 9 months ago (2013-03-08 05:24:05 UTC) #2

*** Submitted as https://code.google.com/p/go/source/detail?r=451d31faf61c ***

cmd/6l, cmd/8l: fix BSD builds

Before this CL, running

        cd misc/cgo/test
        go test -c
        readelf --dyn-syms test.test | grep cgoexp

turned up many UNDEF symbols corresponding to symbols actually
in the binary but marked only cgo_export_static. Only symbols
marked cgo_export_dynamic should be listed in this mode.
And if the symbol is going to be listed, it should be listed with its
actual address instead of UNDEF.

The Linux dynamic linker didn't care about the seemingly missing
symbols, but the BSD one did.

This CL eliminates the symbols from the dyn-syms table.

R=golang-dev
TBR=golang-dev
CC=golang-dev
https://codereview.appspot.com/7624043

Expand All Messages | Collapse All Messages