Add remaining incomplete components of sandbox

Add remaining incomplete components of sandbox

This adds a connection and Python juju API implementation of the in-browser-memory environment.  The final test shows a complete integration of login from environment through to the fake backend.

https://code.launchpad.net/~gary/juju-gui/sandboxEnv-3/+merge/154403

(do not edit description out of merge proposal)

[gary.poster, 2013-03-20 15:20:10]

Please take a look.

[jeff.pihach, 2013-03-20 15:43:58]

LGTM Thanks for the branch!

[matthew.scott, 2013-03-20 15:53:39]

LGTM, thanks!

Few minor points that I don't really care about, just questions.  Feel free to
ignore.

https://codereview.appspot.com/7621048/diff/1/app/store/env/base.js
File app/store/env/base.js (right):

https://codereview.appspot.com/7621048/diff/1/app/store/env/base.js#newcode67
app/store/env/base.js:67: } // else we never connected.
Super minor: we haven't really been doing much in the way of inline comments in
the past.  I'm pretty sure this is meant to be a fake 'else' statement, but
maybe it could go above the if: 

// Close the socket, but only if we have connected.

https://codereview.appspot.com/7621048/diff/1/app/store/env/base.js#newcode84
app/store/env/base.js:84: this.ws.open(); // For the fake backends.
Super minor: inline comment as above.

[gary.poster, 2013-03-20 16:44:54]

*** Submitted:

Add remaining incomplete components of sandbox

This adds a connection and Python juju API implementation of the
in-browser-memory environment.  The final test shows a complete integration of
login from environment through to the fake backend.

R=jeff.pihach, matthew.scott
CC=
https://codereview.appspot.com/7621048

https://codereview.appspot.com/7621048/diff/1/app/store/env/base.js
File app/store/env/base.js (right):

https://codereview.appspot.com/7621048/diff/1/app/store/env/base.js#newcode67
app/store/env/base.js:67: } // else we never connected.
On 2013/03/20 15:53:39, matthew.scott wrote:
> Super minor: we haven't really been doing much in the way of inline comments
in
> the past.  I'm pretty sure this is meant to be a fake 'else' statement, but
> maybe it could go above the if: 
> 
> // Close the socket, but only if we have connected.

Done.

https://codereview.appspot.com/7621048/diff/1/app/store/env/base.js#newcode84
app/store/env/base.js:84: this.ws.open(); // For the fake backends.
On 2013/03/20 15:53:39, matthew.scott wrote:
> Super minor: inline comment as above.

Done.