Issue 7621045: Added the missing ie dep for prod testing

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7621045: Added the missing ie dep for prod testing

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by jeff.pihach

Modified:
11 years, 1 month ago

Reviewers:
benji, matthew.scott, mp+153877

Visibility:
Public.

Description

Added the missing ie dep for prod testing https://code.launchpad.net/~hatch/juju-gui/add-missing-deps/+merge/153877 (do not edit description out of merge proposal)

Patch Set 2 : Added the missing ie dep for prod testing #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -1 line)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	bin/merge-files	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/test_charm_slider.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

benji

LGTM plus the pickiest of nit-picks. https://codereview.appspot.com/7621045/diff/1/bin/merge-files File bin/merge-files (right): https://codereview.appspot.com/7621045/diff/1/bin/merge-files#newcode67 bin/merge-files:67: // causing our ...

11 years, 1 month ago (2013-03-18 17:28:19 UTC) #3

jeff.pihach

11 years, 1 month ago (2013-03-18 17:48:00 UTC) #4

*** Submitted:

Added the missing ie dep for prod testing

R=matthew.scott, benji
CC=
https://codereview.appspot.com/7621045

Expand All Messages | Collapse All Messages