Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1005)

Issue 7621044: code review 7621044: misc/dist: fix Windows breakage

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by Joe Poirier
Modified:
11 years, 10 months ago
Reviewers:
adg
CC:
golang-dev, adg
Visibility:
Public.

Description

misc/dist: fix Windows breakage The files could use some attention on the Windows side but better to wait until after the upcoming release.

Patch Set 1 #

Patch Set 2 : diff -r e4e13824b6a3 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e4e13824b6a3 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M misc/dist/bindist.go View 1 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 4
Joe Poirier
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 2 months ago (2013-03-17 03:06:18 UTC) #1
adg
LGTM Thanks very much.
12 years, 2 months ago (2013-03-17 21:56:13 UTC) #2
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=9f7966fdf741 *** misc/dist: fix Windows breakage The files could use some attention ...
12 years, 2 months ago (2013-03-17 21:56:49 UTC) #3
remyoudompheng
11 years, 10 months ago (2013-07-21 10:23:37 UTC) #4
R=close
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b