code review 7620043: devdraw: control+click = button 2, alt/shift+click = bu...

devdraw: control+click = button 2, alt/shift+click = button 3

For single-button mouse users.

[rsc, 2013-03-08 03:40:44]

Hello rsc,

I'd like you to review this change to
ssh://hg@bitbucket.org/rsc/plan9port

[rsc, 2013-03-08 03:40:54]

*** Submitted as c1bd38a11c42 ***

devdraw: control+click = button 2, alt/shift+click = button 3

For single-button mouse users.

R=rsc
https://codereview.appspot.com/7620043

[iru, 2013-04-09 20:13:46]

On 2013/03/08 03:40:54, rsc wrote:
> *** Submitted as c1bd38a11c42 ***
> 
> devdraw: control+click = button 2, alt/shift+click = button 3
> 
> For single-button mouse users.
> 
> R=rsc
> https://codereview.appspot.com/7620043

Using Ubuntu 12.04, this change breaks:
1. The accent input, i.e. trying to type ã (Alt ~ a) yields ~a (in fact, I need
to type the a two times for it to show).
2. The mouse behavior in acme gets odd sometimes, i.e. cursor in position X, I
click on position Y, acme returns cursor to position X.

[knieriem, 2013-04-28 13:39:35]

https://codereview.appspot.com/7620043/diff/5001/src/cmd/devdraw/x11-itrans.c
File src/cmd/devdraw/x11-itrans.c (right):

https://codereview.appspot.com/7620043/diff/5001/src/cmd/devdraw/x11-itrans.c...
src/cmd/devdraw/x11-itrans.c:156: if(r < 0)
The value of r, which is unsigned now because of the change of r's type to Rune,
cannot be less than 0, so the "return nil" path will never be executed.
Pressing a key like shift will now terminate compose sequences, because such
keys are not filtered out anymore, instead they get propagated to sendrune().

Changing the line to "if (r == -1)" makes it work again, because the -1 is
converted to unsigned int before the comparison.

[rsc, 2013-06-21 19:28:08]

Thanks very much for diagnosing this. Apologies for the long delay.