code review 7597046: runtime: fix build for NetBSD/ARM

runtime: fix build for NetBSD/ARM

[minux1, 2013-03-16 22:13:05]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[jsing, 2013-03-17 01:28:39]

LGTM

https://codereview.appspot.com/7597046/diff/4001/src/pkg/runtime/signal_netbs...
File src/pkg/runtime/signal_netbsd_arm.h (right):

https://codereview.appspot.com/7597046/diff/4001/src/pkg/runtime/signal_netbs...
src/pkg/runtime/signal_netbsd_arm.h:7: // index to the __gregs array of an
mcontext
Any reason not to get these defines via defs_netbsd_arm.h, like we do for
netbsd/386 and netbsd/amd64?

[minux1, 2013-03-17 16:53:39]

On 2013/03/17 01:28:39, jsing wrote:
> Any reason not to get these defines via defs_netbsd_arm.h, like we do for
> netbsd/386 and netbsd/amd64?
the old defs_netbsd_arm.h is manually edited.
i will update a new patch set that use cgo to generate these constants.

[minux1, 2013-03-17 16:54:35]

Hello golang-dev@googlegroups.com, jsing@google.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[jsing, 2013-03-18 03:53:39]

On 2013/03/17 16:54:35, minux wrote:
> Hello mailto:golang-dev@googlegroups.com, mailto:jsing@google.com (cc:
> mailto:golang-dev@googlegroups.com),
> 
> Please take another look.

LGTM

[minux1, 2013-03-18 18:47:21]

*** Submitted as https://code.google.com/p/go/source/detail?r=07e7d82f760e ***

runtime: fix build for NetBSD/ARM

R=golang-dev, jsing
CC=golang-dev
https://codereview.appspot.com/7597046