Issue 7594046: code review 7594046: cmd/ld: replace dynimpname with extname

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7594046: code review 7594046: cmd/ld: replace dynimpname with extname (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by rsc

Modified:
12 years, 2 months ago

Reviewers:

CC:
ken2, golang-dev

Visibility:
Public.

Description

cmd/ld: replace dynimpname with extname Dynimpname was getting too confusing. Replace flag-like checks with tests of s->type.

Patch Set 1 #

Patch Set 2 : diff -r 8377d19921c3 https://go.googlecode.com/hg #

Patch Set 3 : diff -r 8377d19921c3 https://go.googlecode.com/hg #

Patch Set 4 : diff -r 8377d19921c3 https://code.google.com/p/go/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -91 lines)			Patch
M	src/cmd/5l/asm.c	View	1	9 chunks	+9 lines, -16 lines	0 comments	Download
M	src/cmd/5l/l.h	View	1 2 3	2 chunks	+1 line, -1 line	0 comments	Download
M	src/cmd/6l/asm.c	View	1	12 chunks	+13 lines, -19 lines	0 comments	Download
M	src/cmd/6l/l.h	View	1 2 3	2 chunks	+1 line, -1 line	0 comments	Download
M	src/cmd/8l/asm.c	View	1	9 chunks	+11 lines, -16 lines	0 comments	Download
M	src/cmd/8l/l.h	View	1 2 3	2 chunks	+1 line, -1 line	0 comments	Download
M	src/cmd/ld/data.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/ld/elf.c	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/cmd/ld/go.c	View	1	2 chunks	+9 lines, -9 lines	0 comments	Download
M	src/cmd/ld/ldelf.c	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/cmd/ld/ldmacho.c	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/cmd/ld/lib.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/ld/macho.c	View	1	4 chunks	+3 lines, -11 lines	0 comments	Download
M	src/cmd/ld/pe.c	View	1	7 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 2 months ago (2013-03-10 22:19:50 UTC) #1

rsc

12 years, 2 months ago (2013-03-10 22:19:57 UTC) #2

*** Submitted as https://code.google.com/p/go/source/detail?r=969045163653 ***

cmd/ld: replace dynimpname with extname

Dynimpname was getting too confusing.
Replace flag-like checks with tests of s->type.

R=ken2
CC=golang-dev
https://codereview.appspot.com/7594046

Expand All Messages | Collapse All Messages