Issue 7593043: code review 7593043: cmd/8g: fix code generation of int64(0) == int64(0).

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7593043: code review 7593043: cmd/8g: fix code generation of int64(0) == int64(0). (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by remyoudompheng

Modified:
12 years ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

cmd/8g: fix code generation of int64(0) == int64(0). The code would violate the contract of cmp64. Fixes issue 5002.

Patch Set 1 #

Patch Set 2 : diff -r fa80d4256029 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r fa80d4256029 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b7f85d6753ee https://go.googlecode.com/hg/ #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
	M	src/cmd/8g/cgen.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	A	test/fixedbugs/issue5002.go	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

remyoudompheng

Hello rsc@golang.org, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years ago (2013-03-07 20:19:33 UTC) #1

remyoudompheng

12 years ago (2013-03-07 20:49:19 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=5327829ff1e4 ***

cmd/8g: fix code generation of int64(0) == int64(0).

The code would violate the contract of cmp64.

Fixes issue 5002.

R=rsc, golang-dev
CC=golang-dev
https://codereview.appspot.com/7593043

Expand All Messages | Collapse All Messages