Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1756)

Issue 75920043: code review 75920043: net: deflake TestTCPConcurrentAccept (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years ago by mikio
Modified:
6 years ago
Reviewers:
gobot, jsing
CC:
jsing, golang-codereviews
Visibility:
Public.

Description

net: deflake TestTCPConcurrentAccept Some platform that implements inp_localgroup-like shared internet protocol control block group looks a bit sensitive about transport layer protocol's address:port reuse. Sometimes it rejects a TCP SYN packet using TCP RST, and sometimes silence. For now, until test case refactoring, we admit few Dial failures on TestTCPConcurrentAccept as a workaround. Update issue 7400 Update issue 7541

Patch Set 1 : diff -r 08dcdcdb757b https://code.google.com/p/go #

Patch Set 2 : diff -r 32b8c26e4414 https://code.google.com/p/go #

Total comments: 2

Patch Set 3 : diff -r 5f662f12d550 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M src/pkg/net/tcp_test.go View 1 2 2 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 4
mikio
Hello jsing@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
6 years ago (2014-03-14 08:23:32 UTC) #1
jsing
LGTM Consider adding "Update issue 7400" to description. https://codereview.appspot.com/75920043/diff/100001/src/pkg/net/tcp_test.go File src/pkg/net/tcp_test.go (right): https://codereview.appspot.com/75920043/diff/100001/src/pkg/net/tcp_test.go#newcode481 src/pkg/net/tcp_test.go:481: if ...
6 years ago (2014-03-25 11:57:23 UTC) #2
mikio
*** Submitted as https://code.google.com/p/go/source/detail?r=3cc84a8a3956 *** net: deflake TestTCPConcurrentAccept Some platform that implements inp_localgroup-like shared internet ...
6 years ago (2014-03-26 02:43:45 UTC) #3
gobot
6 years ago (2014-03-26 05:24:22 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the openbsd-386-rootbsd builder.
See http://build.golang.org/log/1cd361e2ecae2b70c92b61e070ae24adfb745e46
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b