code review 75900043: net: make use of Errorf instead of Fatalf in non-test f...

net: make use of testing.Errorf instead of testing.Fatalf in non-test function goroutines

See testing.FailNow for further information.

[mikio, 2014-03-14 08:23:21]

Hello golang-codereviews@googlegroups.com (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[iant, 2014-03-14 13:29:38]

LGTM

[mikio, 2014-03-14 15:50:50]

PTAL

swept away all test files in net.

[iant, 2014-03-14 17:39:23]

https://codereview.appspot.com/75900043/diff/60001/src/pkg/net/server_test.go
File src/pkg/net/server_test.go (right):

https://codereview.appspot.com/75900043/diff/60001/src/pkg/net/server_test.go...
src/pkg/net/server_test.go:218: t.Errorf("Dial(%q, %q) failed: %v", net, taddr,
err)
This one is not being run in a goroutine.  It could be Fatal.

https://codereview.appspot.com/75900043/diff/60001/src/pkg/net/server_test.go...
src/pkg/net/server_test.go:405: t.Errorf("Dial(%q, %q) failed: %v", net, taddr,
err)
This one is also not being run in a goroutine.

https://codereview.appspot.com/75900043/diff/60001/src/pkg/net/server_test.go...
src/pkg/net/server_test.go:441: t.Errorf("ResolveUDPAddr(%q, %q) failed: %v",
net, taddr, err)
This one is also not being run in a goroutine.

[mikio, 2014-03-15 04:10:17]

ptal

https://codereview.appspot.com/75900043/diff/60001/src/pkg/net/server_test.go
File src/pkg/net/server_test.go (right):

https://codereview.appspot.com/75900043/diff/60001/src/pkg/net/server_test.go...
src/pkg/net/server_test.go:218: t.Errorf("Dial(%q, %q) failed: %v", net, taddr,
err)
On 2014/03/14 17:39:24, iant wrote:
> This one is not being run in a goroutine.  It could be Fatal.

Done.

https://codereview.appspot.com/75900043/diff/60001/src/pkg/net/server_test.go...
src/pkg/net/server_test.go:405: t.Errorf("Dial(%q, %q) failed: %v", net, taddr,
err)
On 2014/03/14 17:39:24, iant wrote:
> This one is also not being run in a goroutine.

Done.

https://codereview.appspot.com/75900043/diff/60001/src/pkg/net/server_test.go...
src/pkg/net/server_test.go:441: t.Errorf("ResolveUDPAddr(%q, %q) failed: %v",
net, taddr, err)
On 2014/03/14 17:39:24, iant wrote:
> This one is also not being run in a goroutine.

Done.

[iant, 2014-03-15 04:25:31]

LGTM

[mikio, 2014-03-15 04:43:12]

*** Submitted as https://code.google.com/p/go/source/detail?r=d5f80a4411a5 ***

net: make use of testing.Errorf instead of testing.Fatalf in non-test function
goroutines

See testing.FailNow for further information.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/75900043