Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2154)

Issue 75830045: Improve bundle URLs support.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by frankban
Modified:
10 years, 1 month ago
Reviewers:
bac, mp+211057
Visibility:
Public.

Description

Improve bundle URLs support. Add support for promulgated bundle short names. Add support for jujucharms bundle URLs. Improve help messages. Tests: `make check`. QA: Run `.venv/bin/python juju-quickstart -h` and please check the spelling of the whole help message. Also ensure it is nicely printed on a small terminal (e.g. 80x24). Now let's check bundle errors: all the commands below should return a pertinent error message: .venv/bin/python juju-quickstart bundle: .venv/bin/python juju-quickstart https://jujucharms.com/bundle/mediawiki/single/wtf .venv/bin/python juju-quickstart https://jujucharms.com/bundle/mediawiki/double .venv/bin/python juju-quickstart https://jujucharms.com/charms/mediawiki/single .venv/bin/python juju-quickstart bundle:mediawiki/42/single .venv/bin/python juju-quickstart bundle:~frankban/mediawiki/single Deploy bundles, destroy the environment after each command. Deploy the promulgated mediawiki single bundle: .venv/bin/python juju-quickstart bundle:~charmers/mediawiki/6/single Deploy the mediawiki scalable bundle: .venv/bin/python juju-quickstart bundle:mediawiki/scalable Deploy a bundle using its jujucharms URLs: .venv/bin/python juju-quickstart https://jujucharms.com/bundle/~bac/charmworld-demo/charmworld-minimal/ Deploy a bundle using direct HTTPS: .venv/bin/python juju-quickstart https://raw.github.com/castrojo/mongodb-bundle/master/bundles.yaml https://code.launchpad.net/~frankban/juju-quickstart/bundle-urls/+merge/211057 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 12

Patch Set 2 : Improve bundle URLs support. #

Patch Set 3 : Improve bundle URLs support. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -47 lines) Patch
M README.rst View 1 1 chunk +2 lines, -2 lines 0 comments Download
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M quickstart/__init__.py View 1 1 chunk +24 lines, -1 line 0 comments Download
M quickstart/manage.py View 1 5 chunks +51 lines, -25 lines 0 comments Download
M quickstart/settings.py View 1 chunk +4 lines, -1 line 0 comments Download
M quickstart/tests/test_manage.py View 1 2 chunks +23 lines, -0 lines 0 comments Download
M quickstart/tests/test_utils.py View 1 chunk +103 lines, -16 lines 0 comments Download
M quickstart/utils.py View 3 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 7
frankban
Please take a look.
10 years, 1 month ago (2014-03-14 14:16:47 UTC) #1
rharding
Thanks for this, mainly reviewed the docs. A couple of suggestions. Let me know if ...
10 years, 1 month ago (2014-03-14 14:37:07 UTC) #2
bac
Code LGTM https://codereview.appspot.com/75830045/diff/1/quickstart/__init__.py File quickstart/__init__.py (right): https://codereview.appspot.com/75830045/diff/1/quickstart/__init__.py#newcode33 quickstart/__init__.py:33: (installing on an existing state server when ...
10 years, 1 month ago (2014-03-14 14:51:19 UTC) #3
frankban
Please take a look. https://codereview.appspot.com/75830045/diff/1/quickstart/__init__.py File quickstart/__init__.py (right): https://codereview.appspot.com/75830045/diff/1/quickstart/__init__.py#newcode33 quickstart/__init__.py:33: (installing on an existing state ...
10 years, 1 month ago (2014-03-14 18:27:54 UTC) #4
bac
QA good. Thanks.
10 years, 1 month ago (2014-03-14 18:34:08 UTC) #5
frankban
*** Submitted: Improve bundle URLs support. Add support for promulgated bundle short names. Add support ...
10 years, 1 month ago (2014-03-17 08:59:40 UTC) #6
frankban
10 years, 1 month ago (2014-03-17 09:14:21 UTC) #7
Thank you Rick and Brad!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b