Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(649)

Issue 7579045: code review 7579045: database/sql: fix Conn leak (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by bradfitz
Modified:
7 years, 10 months ago
Reviewers:
CC:
golang-dev, brainman, r, julienschmidt
Visibility:
Public.

Description

database/sql: fix Conn leak Fixes issue 4902

Patch Set 1 #

Patch Set 2 : diff -r 5b76706b55af https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0a292c902314 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 0a292c902314 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 70d1d0a4bcab https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M src/pkg/database/sql/sql.go View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/database/sql/sql_test.go View 1 2 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 5
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
7 years, 10 months ago (2013-03-08 02:49:54 UTC) #1
brainman
No computers here. Just sand and sea. I will look at it next week when ...
7 years, 10 months ago (2013-03-08 05:05:06 UTC) #2
r
LGTM
7 years, 10 months ago (2013-03-08 06:03:09 UTC) #3
julienschmidt
LGTM
7 years, 10 months ago (2013-03-08 12:24:34 UTC) #4
bradfitz
7 years, 10 months ago (2013-03-08 18:04:12 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=3486a9feedda ***

database/sql: fix Conn leak

Fixes issue 4902

R=golang-dev, alex.brainman, r, google
CC=golang-dev
https://codereview.appspot.com/7579045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b