Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(449)

Issue 7577044: code review 7577044: text/template: revert minor change to Name method (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by r
Modified:
12 years, 2 months ago
Reviewers:
CC:
golang-dev, dsymonds
Visibility:
Public.

Description

text/template: revert minor change to Name method For better printing, I recently changed Name to return "<unnamed>" for templates with empty names, but this causes trouble for the many packages that used "" as the template name, so restore the old behavior. It's usually printed as a quoted string anyway, so it should be fine.

Patch Set 1 #

Patch Set 2 : diff -r feca70ca7e83 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M src/pkg/text/template/template.go View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
12 years, 2 months ago (2013-03-08 23:25:47 UTC) #1
dsymonds
LGTM
12 years, 2 months ago (2013-03-09 00:02:07 UTC) #2
r
12 years, 2 months ago (2013-03-09 00:39:56 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=80a76d7f37a1 ***

text/template: revert minor change to Name method
For  better printing, I recently changed Name to return "<unnamed>" for
templates
with empty names, but this causes trouble for the many packages that used "" as
the template name, so restore the old behavior.
It's usually printed as a quoted string anyway, so it should be fine.

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/7577044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b