Issue 7573043: Test refactoring around MakeFakeHome

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7573043: Test refactoring around MakeFakeHome

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by thumper

Modified:
11 years, 2 months ago

Reviewers:
dimitern, dave, mp+152054

Visibility:
Public.

Description

Test refactoring around MakeFakeHome https://code.launchpad.net/~thumper/juju-core/juju-env/+merge/152054 (do not edit description out of merge proposal)

Patch Set 2 : respect the JUJU_ENV environment variable #

Total comments: 2

Patch Set 3 : Test refactoring around MakeFakeHome #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+162 lines, -94 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/config_test.go	View		9 chunks	+7 lines, -40 lines	0 comments	Download
M	environs/open_test.go	View		3 chunks	+20 lines, -1 line	0 comments	Download
M	juju/conn_test.go	View	1	1 chunk	+41 lines, -53 lines	0 comments	Download
A	testing/environ.go	View	1 2	1 chunk	+92 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

thumper

On 07/03/13 10:19, tim.penhey@canonical.com wrote: > Reviewers: mp+152054_code.launchpad.net, > > Message: > Please take a ...

11 years, 2 months ago (2013-03-07 15:22:21 UTC) #2

dave_cheney.net

LGTM. https://codereview.appspot.com/7573043/diff/4001/juju/conn_test.go File juju/conn_test.go (right): https://codereview.appspot.com/7573043/diff/4001/juju/conn_test.go#newcode60 juju/conn_test.go:60: _, err := juju.NewConnFromName("") NewConnFromName("") hurts to read ...

11 years, 2 months ago (2013-03-08 17:06:04 UTC) #5

thumper

11 years, 2 months ago (2013-03-08 18:19:32 UTC) #6

*** Submitted:

Test refactoring around MakeFakeHome

R=dimitern, dfc
CC=
https://codereview.appspot.com/7573043

Expand All Messages | Collapse All Messages