adding search_term to AttachList macro

adding search_term to AttachList macro

[ReimarBauer, 2013-03-07 15:14:32]

info

https://codereview.appspot.com/7571043/diff/1/MoinMoin/macro/AttachList.py
File MoinMoin/macro/AttachList.py (right):

https://codereview.appspot.com/7571043/diff/1/MoinMoin/macro/AttachList.py#ne...
MoinMoin/macro/AttachList.py:19: def macro_AttachList(macro, pagename=None,
mime_type=u'*', search_term=u'.+'):
For my use case it can be search or match

I am undecided here. search is may be more comfortable.

[Thomas.J.Waldmann, 2013-03-07 22:39:20]

https://codereview.appspot.com/7571043/diff/1/MoinMoin/action/AttachFile.py
File MoinMoin/action/AttachFile.py (right):

https://codereview.appspot.com/7571043/diff/1/MoinMoin/action/AttachFile.py#n...
MoinMoin/action/AttachFile.py:324: files = [fname for fname in files if
filterfn(fname)]
looks ok and compatible. :)

btw: for what do you need it precisely?

https://codereview.appspot.com/7571043/diff/1/MoinMoin/macro/AttachList.py
File MoinMoin/macro/AttachList.py (right):

https://codereview.appspot.com/7571043/diff/1/MoinMoin/macro/AttachList.py#ne...
MoinMoin/macro/AttachList.py:16: import re
add an empty line afterwards, please

https://codereview.appspot.com/7571043/diff/1/MoinMoin/macro/AttachList.py#ne...
MoinMoin/macro/AttachList.py:23: filterfn = re.compile(search_term, re.U).search
check whether you want .search or .match

[ReimarBauer, 2013-03-07 22:51:59]

answered

https://codereview.appspot.com/7571043/diff/1/MoinMoin/action/AttachFile.py
File MoinMoin/action/AttachFile.py (right):

https://codereview.appspot.com/7571043/diff/1/MoinMoin/action/AttachFile.py#n...
MoinMoin/action/AttachFile.py:324: files = [fname for fname in files if
filterfn(fname)]
On 2013/03/07 22:39:21, Thomas.J.Waldmann wrote:
> looks ok and compatible. :)
> 
> btw: for what do you need it precisely?

we have a lot ozone sonde data files and the first two chars indicate the
station. The date of measurement and extension are identical. They should be
listed for the different stations on one page. Some of them also by date.

[ReimarBauer, 2013-03-08 07:35:03]

decided to use .search

https://codereview.appspot.com/7571043/diff/1/MoinMoin/macro/AttachList.py
File MoinMoin/macro/AttachList.py (right):

https://codereview.appspot.com/7571043/diff/1/MoinMoin/macro/AttachList.py#ne...
MoinMoin/macro/AttachList.py:23: filterfn = re.compile(search_term, re.U).search
On 2013/03/07 22:39:21, Thomas.J.Waldmann wrote:
> check whether you want .search or .match

.search is appropriate one can add ^ to start from the beginning.