Fix the naming of export_dll.lib to work with Ninja.

Fix the naming of export_dll.lib to work with Ninja.

The name of the 'lib' can be renamed with msvs.
I didn't find an easy way to do the same with ninja.
Thus, I use the ninja naming convention for the output
lib file.

R=chrisha@chromium.org, sebmarchand@chromium.org

Committed: https://code.google.com/p/sawbuck/source/detail?r=2083

[etienneb, 2014-03-14 05:04:13]

PTAL.

[chrisha, 2014-03-14 13:23:21]

Where do you indicate to the MSVS generator to change the lib name?

Also, maybe do this for *all* libs by changing the default VCLinkerTool defaults
in syzygy.gypi (our common.gypi overrides).

[etienneb, 2014-03-14 14:45:01]

I forgot to include the syzygy.gypi.
My bad.

Here is the fix.

[Sébastien Marchand, 2014-03-14 14:56:37]

lgtm (but I suggest that you do an official build of the target binaries_zip to
double check)

[etienneb, 2014-03-14 17:39:18]

I added the modification for Syzyasan_lib.
It's under test.

[chrisha, 2014-03-14 17:47:37]

Do a git grep for syzyasan_rtl.lib and you'll see that you also need to modify
build/README.TXT.template

Shouldn't you also be able to remove the changes you added to create_lib_zip in
build/all.gyp?

https://codereview.appspot.com/75680044/diff/40001/syzygy/agent/asan/asan.gyp
File syzygy/agent/asan/asan.gyp (right):

https://codereview.appspot.com/75680044/diff/40001/syzygy/agent/asan/asan.gyp...
syzygy/agent/asan/asan.gyp:111: # Force MSVS to produce the same output name
than Ninja.
as* Ninja.

https://codereview.appspot.com/75680044/diff/40001/syzygy/pe/pe.gyp
File syzygy/pe/pe.gyp (right):

https://codereview.appspot.com/75680044/diff/40001/syzygy/pe/pe.gyp#newcode285
syzygy/pe/pe.gyp:285: # Force MSVS to produce the same output name than Ninja.
same output name as* Ninja.

[etienneb, 2014-03-14 17:59:26]

> Shouldn't you also be able to remove the changes you added to create_lib_zip
in build/all.gyp?

No, it's the same name, but not same output directory.

This is supposed to be copied where?

[chrisha, 2014-03-14 18:00:24]

The generating lib.zip gets uploaded as part of the official binaries.


On Fri, Mar 14, 2014 at 1:59 PM, <etienneb@chromium.org> wrote:

> Shouldn't you also be able to remove the changes you added to
>>
> create_lib_zip in build/all.gyp?
>
> No, it's the same name, but not same output directory.
>
> This is supposed to be copied where?
>
> https://codereview.appspot.com/75680044/
>

[etienneb, 2014-03-14 18:05:48]

On 2014/03/14 18:00:24, chrisha wrote:
> The generating lib.zip gets uploaded as part of the official binaries.
> 
> 
> On Fri, Mar 14, 2014 at 1:59 PM, <mailto:etienneb@chromium.org> wrote:
> 
> > Shouldn't you also be able to remove the changes you added to
> >>
> > create_lib_zip in build/all.gyp?
> >
> > No, it's the same name, but not same output directory.
> >
> > This is supposed to be copied where?
> >
> > https://codereview.appspot.com/75680044/
> >

Ok, so it should work as-is.
I clean all my sub-folders and try again (~ 30min).

[etienneb, 2014-03-14 20:40:07]

Tests are running correctly.
Archives are valid.
PTAnL.

[Sébastien Marchand, 2014-03-14 20:42:28]

lgtm

[chrisha, 2014-03-14 20:49:32]

Ditto, lgtm!

[etienneb, 2014-03-14 21:01:35]

thanks, committing...
towards a Ninja build.

[etienneb, 2014-03-14 21:15:04]

Committed patchset #6 manually as r2083 (presubmit successful).