Move build_output_dir detection to GYP files.

Move build_output_dir detection to GYP files.

R=chrisha@chromium.org

Committed: https://code.google.com/p/sawbuck/source/detail?r=2082

[etienneb, 2014-03-14 03:41:08]

PTAL.

This patch fixes most of the broken unittests with the Ninja build. Most of them
are related to the path expansion for "test_dll".

[chrisha, 2014-03-14 13:21:40]

Given that we've got a lot of paths that are now generator dependent, maybe we
simply want to expose the generator itself via _GYP_GENERATOR? Then do things
with preprocessor statements as we've always done?

[etienneb, 2014-03-14 14:16:12]

On 2014/03/14 13:21:40, chrisha wrote:
> Given that we've got a lot of paths that are now generator dependent, maybe we
> simply want to expose the generator itself via _GYP_GENERATOR? Then do things
> with preprocessor statements as we've always done?

I don't think adding dependencies related to the build into the code is a good
idea.
Output paths are build information, not a code source information.

There seems to have only to case to manage: test_dll.dll and export_dll.

[chrisha, 2014-03-14 14:26:54]

Point well taken regarding build system vs source code.

lgtm with a nit!

https://codereview.appspot.com/75650044/diff/1/syzygy/syzygy.gypi
File syzygy/syzygy.gypi (right):

https://codereview.appspot.com/75650044/diff/1/syzygy/syzygy.gypi#newcode124
syzygy/syzygy.gypi:124: # Specify the output directory into
<(PRODUCT_DIR)/build/.
Remove this outdated comment? Ditto above.

[etienneb, 2014-03-14 20:46:14]

thanks, committing...

https://codereview.appspot.com/75650044/diff/1/syzygy/syzygy.gypi
File syzygy/syzygy.gypi (right):

https://codereview.appspot.com/75650044/diff/1/syzygy/syzygy.gypi#newcode124
syzygy/syzygy.gypi:124: # Specify the output directory into
<(PRODUCT_DIR)/build/.
On 2014/03/14 14:26:55, chrisha wrote:
> Remove this outdated comment? Ditto above.

Done.

[etienneb, 2014-03-14 20:59:58]

Committed patchset #2 manually as r2082 (presubmit successful).