Issue 75630044: Remove Checkers Dir

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 75630044: Remove Checkers Dir

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by waigani

Modified:
10 years, 2 months ago

Reviewers:
axw, mp+210935

Visibility:
Public.

Description

Remove Checkers Dir We now get checkers from github branch. https://code.launchpad.net/~waigani/juju-core/remove-checkers-dir/+merge/210935 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -1697 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
D	testing/checkers/bool.go	View	1 chunk	+0 lines, -115 lines	0 comments	Download
D	testing/checkers/bool_test.go	View	1 chunk	+0 lines, -120 lines	0 comments	Download
D	testing/checkers/checker.go	View	1 chunk	+0 lines, -202 lines	0 comments	Download
D	testing/checkers/checker_test.go	View	1 chunk	+0 lines, -119 lines	0 comments	Download
D	testing/checkers/deepequal.go	View	1 chunk	+0 lines, -303 lines	0 comments	Download
D	testing/checkers/deepequal_test.go	View	1 chunk	+0 lines, -171 lines	0 comments	Download
D	testing/checkers/file.go	View	1 chunk	+0 lines, -154 lines	0 comments	Download
D	testing/checkers/file_test.go	View	1 chunk	+0 lines, -165 lines	0 comments	Download
D	testing/checkers/log.go	View	1 chunk	+0 lines, -109 lines	0 comments	Download
D	testing/checkers/log_test.go	View	1 chunk	+0 lines, -111 lines	0 comments	Download
D	testing/checkers/relop.go	View	1 chunk	+0 lines, -93 lines	0 comments	Download
D	testing/checkers/relop_test.go	View	1 chunk	+0 lines, -35 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

axw

10 years, 2 months ago (2014-03-14 01:09:16 UTC) #2

On 2014/03/13 23:19:53, waigani wrote:
> Please take a look.

LGTM

Expand All Messages | Collapse All Messages