Issue 7554047: Allow passing app config through app to subapps.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7554047: Allow passing app config through app to subapps.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by rharding

Modified:
11 years, 1 month ago

Reviewers:
mp+153451, jeff.pihach, j.c.sackett

Visibility:
Public.

Description

Allow passing app config through app to subapps. - Adjusted the addSubApplications call to allow passing config - Add a blacklist of config we know that SubApps should never inherit from the main App. - Merge the application config with any config specified in the subApplications prototype list of subapps to mount. - Add a test that we can create app/subapp and that the config is merged correctly. https://code.launchpad.net/~rharding/juju-gui/subapp_config/+merge/153451 (do not edit description out of merge proposal)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -8 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/app.js	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	app/assets/javascripts/app-subapp-extension.js	View	1	3 chunks	+27 lines, -4 lines	0 comments	Download
M	app/config-debug.js	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	app/config-prod.js	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	test/test_subapp_app_extension.js	View	1	1 chunk	+42 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jeff.pihach

LGTM land with changes. Thanks for creating this feature it's definitely needed! Just one small ...

11 years, 1 month ago (2013-03-14 19:48:42 UTC) #3

rharding

11 years, 1 month ago (2013-03-15 01:00:11 UTC) #4

*** Submitted:

Allow passing app config through app to subapps.

- Adjusted the addSubApplications call to allow passing config
- Add a blacklist of config we know that SubApps should never inherit from the
main App.
- Merge the application config with any config specified in the
subApplications prototype list of subapps to mount.
- Add a test that we can create app/subapp and that the config is merged
correctly.

R=jeff.pihach
CC=
https://codereview.appspot.com/7554047

Expand All Messages | Collapse All Messages