Issue 7551046: environs/jujutest: always sort during checkList

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7551046: environs/jujutest: always sort during checkList (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by dave

Modified:
11 years, 2 months ago

Reviewers:
mp+152192

Visibility:
Public.

Description

environs/jujutest: always sort during checkList Fix LP#1152202 by sorting the arrays to compare inside checkList. This is a temporary fix until I can get an SliceEquals checker added to gocheck. https://code.launchpad.net/~dave-cheney/juju-core/101-lp-1152202/+merge/152192 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/jujutest: always sort during checkList #

Patch Set 3 : environs/jujutest: always sort during checkList #

Patch Set 4 : environs/jujutest: always sort during checkList #

Patch Set 5 : environs/jujutest: always sort during checkList #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
	A	[revision details]	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	environs/jujutest/tests.go	View	1 2 3	2 chunks	+14 lines, -1 line	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

dimitern

Thanks, LGTM! Very nice, we definitely need this in gocheck!

11 years, 2 months ago (2013-03-07 15:38:56 UTC) #4

dave_cheney.net

On 2013/03/07 15:38:56, dimitern wrote: > Thanks, LGTM! Very nice, we definitely need this in ...

11 years, 2 months ago (2013-03-08 14:20:57 UTC) #5

dave_cheney.net

11 years, 2 months ago (2013-03-09 16:36:57 UTC) #8

*** Submitted:

environs/jujutest: always sort during checkList

Fix LP#1152202 by sorting the arrays to compare inside checkList. This is a
temporary fix until I can get an SliceEquals checker added to gocheck.

R=dimitern, fwereade
CC=
https://codereview.appspot.com/7551046

Expand All Messages | Collapse All Messages