Issue 7548043: code review 7548043: cmd/6a, cmd/8a, cmd/6l, cmd/8l: add AES instructions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7548043: code review 7548043: cmd/6a, cmd/8a, cmd/6l, cmd/8l: add AES instructions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by khr

Modified:
11 years, 1 month ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

cmd/6a, cmd/8a, cmd/6l, cmd/8l: add AES instructions Instructions for use in AES hashing. See CL#7543043

Patch Set 1 #

Patch Set 2 : diff -r 37d4691df584 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 37d4691df584 https://code.google.com/p/go/ #

Patch Set 4 : diff -r b7f85d6753ee https://code.google.com/p/go/ #

Patch Set 5 : diff -r 5327829ff1e4 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 5327829ff1e4 https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r 5327829ff1e4 https://go.googlecode.com/hg/ #

Patch Set 8 : diff -r 5327829ff1e4 https://go.googlecode.com/hg/ #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1020 lines, -777 lines)			Patch
M	src/cmd/6a/lex.c	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/cmd/6l/6.out.h	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/cmd/6l/l.h	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	src/cmd/6l/optab.c	View	1	4 chunks	+13 lines, -0 lines	0 comments	Download
M	src/cmd/6l/span.c	View	1	2 chunks	+10 lines, -0 lines	0 comments	Download
M	src/cmd/8a/a.y	View	1	4 chunks	+13 lines, -2 lines	0 comments	Download
M	src/cmd/8a/lex.c	View	1	5 chunks	+6 lines, -0 lines	0 comments	Download
M	src/cmd/8a/y.tab.h	View	1	6 chunks	+40 lines, -58 lines	0 comments	Download
M	src/cmd/8a/y.tab.c	View	1	69 chunks	+865 lines, -711 lines	0 comments	Download
M	src/cmd/8l/8.out.h	View	1 2	4 chunks	+9 lines, -1 line	0 comments	Download
M	src/cmd/8l/l.h	View	1	4 chunks	+4 lines, -1 line	0 comments	Download
M	src/cmd/8l/optab.c	View	1 2	6 chunks	+30 lines, -1 line	0 comments	Download
M	src/cmd/8l/span.c	View	1	2 chunks	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Please make the CL description say cmd/6a, cmd/8a, cmd/6l, cmd/8l: add AES instructions it's just ...

11 years, 1 month ago (2013-03-07 02:45:35 UTC) #2

khr

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 1 month ago (2013-03-07 20:47:53 UTC) #3

khr

11 years, 1 month ago (2013-03-07 20:54:18 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=479ac38abfc9 ***

cmd/6a, cmd/8a, cmd/6l, cmd/8l: add AES instructions

Instructions for use in AES hashing.  See CL#7543043

R=rsc
CC=golang-dev
https://codereview.appspot.com/7548043

Expand All Messages | Collapse All Messages