code review 7546049: build: skip benchmarks on OpenBSD

build: skip benchmarks on OpenBSD

They are making the build die. I want to be able to see that everything else is okay.

[rsc, 2013-03-15 15:47:34]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2013-03-15 15:49:21]

LGTM
 On Mar 15, 2013 8:47 AM, <rsc@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> build: skip benchmarks on OpenBSD
>
> They are making the build die. I want to be able to see that everything
> else is okay.
>
> Please review this at
https://codereview.appspot.**com/7546049/<https://codereview.appspot.com/7546...
>
> Affected files:
>   M src/run.bash
>
>
> Index: src/run.bash
> ==============================**==============================**=======
> --- a/src/run.bash
> +++ b/src/run.bash
> @@ -116,9 +116,12 @@
>  ./timing.sh -test
>  ) || exit $?
>
> +[ "$GOOS" == openbsd ] || # golang.org/issue/5057
> +(
>  echo
>  echo '#' ../test/bench/go1
>  go test ../test/bench/go1
> +) || exit $?
>
>  (xcd ../test
>  unset GOMAXPROCS
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[rsc, 2013-03-15 16:39:18]

*** Submitted as https://code.google.com/p/go/source/detail?r=16f65c9ab399 ***

build: skip benchmarks on OpenBSD

They are making the build die. I want to be able to see that everything else is
okay.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7546049

[bsiegert, 2013-03-16 10:00:09]

Doesn't help:

# ../test
run                  nilptr.go           : incorrect output
signal: segmentation fault

On Fri, Mar 15, 2013 at 5:39 PM,  <rsc@golang.org> wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=16f65c9ab399 ***
>
>
> build: skip benchmarks on OpenBSD
>
> They are making the build die. I want to be able to see that everything
> else is okay.
>
> R=golang-dev, bradfitz
> CC=golang-dev
> https://codereview.appspot.com/7546049
>
>
> https://codereview.appspot.com/7546049/
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>



--
The first essential in chemistry is that you should perform practical
work and conduct experiments, for he who performs not practical work
nor makes experiments will never attain the least degree of mastery.
        -- Abu Musa Jabir ibn Hayyan (721-815)

[jsing, 2013-03-17 15:35:27]

On 16 March 2013 21:00, Benny Siegert <bsiegert@gmail.com> wrote:
> Doesn't help:
>
> # ../test
> run                  nilptr.go           : incorrect output
> signal: segmentation fault

I believe the new builder is running with a data seg size ulimit of
512MB, which is why these tests are failing. However, it is great when
this not only exposes a bug in the OpenBSD runtime, but bugs in the
runtimes for multiple platforms :)