Issue 7540043: code review 7540043: net/http/httputil: fix build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7540043: code review 7540043: net/http/httputil: fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by rsc

Modified:
12 years, 3 months ago

Reviewers:

CC:
bradfitz, golang-dev

Visibility:
Public.

Description

net/http/httputil: fix build

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/pkg/net/http/httputil/dump_test.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello bradfitz (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 3 months ago (2013-03-06 21:56:50 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=bc4ace1381c9 *** net/http/httputil: fix build TBR=bradfitz CC=golang-dev https://codereview.appspot.com/7540043

12 years, 3 months ago (2013-03-06 21:56:57 UTC) #2

bradfitz

12 years, 3 months ago (2013-03-06 22:02:14 UTC) #3

LGTM

On Wed, Mar 6, 2013 at 1:56 PM, <rsc@golang.org> wrote:

> Reviewers: bradfitz,
>
> Message:
> Hello bradfitz (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> net/http/httputil: fix build
>
> Please review this at
https://codereview.appspot.**com/7540043/<https://codereview.appspot.com/7540...
>
> Affected files:
>   M src/pkg/net/http/httputil/**dump_test.go
>
>
> Index: src/pkg/net/http/httputil/**dump_test.go
> ==============================**==============================**=======
> --- a/src/pkg/net/http/httputil/**dump_test.go
> +++ b/src/pkg/net/http/httputil/**dump_test.go
> @@ -68,7 +68,7 @@
>
>                 WantDumpOut: "GET /foo HTTP/1.1\r\n" +
>                         "Host: example.com\r\n" +
> -                       "User-Agent: Go http package\r\n" +
> +                       "User-Agent: Go 1.1 package http\r\n" +
>                         "Accept-Encoding: gzip\r\n\r\n",
>         },
>
> @@ -80,7 +80,7 @@
>
>                 WantDumpOut: "GET /foo HTTP/1.1\r\n" +
>                         "Host: example.com\r\n" +
> -                       "User-Agent: Go http package\r\n" +
> +                       "User-Agent: Go 1.1 package http\r\n" +
>                         "Accept-Encoding: gzip\r\n\r\n",
>         },
>  }
>
>
>

Expand All Messages | Collapse All Messages