Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(106)

Issue 7532043: code review 7532043: net/http: change user agent string (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 6 months ago by rsc
Modified:
8 years, 6 months ago
Reviewers:
CC:
golang-dev, bradfitz, minux1
Visibility:
Public.

Description

net/http: change user agent string Some IDS somewhere thinks "Go http package" is a virus. Make it something else for Go 1.1. Dumb but easy.

Patch Set 1 #

Patch Set 2 : diff -r d9a5413ba789 https://code.google.com/p/go/ #

Patch Set 3 : diff -r d9a5413ba789 https://code.google.com/p/go/ #

Patch Set 4 : diff -r d9a5413ba789 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 5 : diff -r 3beef801220b https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -21 lines) Patch
M src/pkg/net/http/export_test.go View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/net/http/header_test.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/http/request.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/http/request_test.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/http/requestwrite_test.go View 1 13 chunks +18 lines, -18 lines 0 comments Download

Messages

Total messages: 7
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
8 years, 6 months ago (2013-03-06 20:35:04 UTC) #1
bradfitz
use the constant defaultUserAgent in the tests? could be forwarded from export_test.go. On Wed, Mar ...
8 years, 6 months ago (2013-03-06 20:38:31 UTC) #2
rsc
Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
8 years, 6 months ago (2013-03-06 20:47:37 UTC) #3
minux1
given Go's popularity and Go 1.1's various improvements, i expect that virus writers will also ...
8 years, 6 months ago (2013-03-06 20:56:21 UTC) #4
bradfitz
LGTM https://codereview.appspot.com/7532043/diff/9001/src/pkg/net/http/requestwrite_test.go File src/pkg/net/http/requestwrite_test.go (right): https://codereview.appspot.com/7532043/diff/9001/src/pkg/net/http/requestwrite_test.go#newcode96 src/pkg/net/http/requestwrite_test.go:96: "User-Agent: Go 1.1 package http\r\n" + use the ...
8 years, 6 months ago (2013-03-06 20:57:40 UTC) #5
rsc
i think it's fine with the concats. it's just a test.
8 years, 6 months ago (2013-03-06 21:47:48 UTC) #6
rsc
8 years, 6 months ago (2013-03-06 21:48:25 UTC) #7
*** Submitted as https://code.google.com/p/go/source/detail?r=ca2b2e58fb69 ***

net/http: change user agent string

Some IDS somewhere thinks "Go http package" is a virus.
Make it something else for Go 1.1. Dumb but easy.

R=golang-dev, bradfitz, minux.ma
CC=golang-dev
https://codereview.appspot.com/7532043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b