Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(55)

Issue 7531049: Add .npmignore file (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by arv
Modified:
13 years, 2 months ago
Reviewers:
usrbincc
CC:
traceur-compiler-reviews_googlegroups.com
Base URL:
https://code.google.com/p/traceur-compiler/@master
Visibility:
Public.

Description

Add .npmignore file BUG=https://code.google.com/p/traceur-compiler/issues/detail?id=225 Committed: https://code.google.com/p/traceur-compiler/source/detail?r=af93a22

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
A .npmignore View 1 chunk +6 lines, -0 lines 1 comment Download

Messages

Total messages: 7
arv
Right now I include the whole src even though I think only src/node/* is needed ...
13 years, 2 months ago (2013-03-25 18:59:11 UTC) #1
usrbincc
After reading that .npmignore uses the same format as .gitignore, I tried this, and it ...
13 years, 2 months ago (2013-03-25 21:06:16 UTC) #2
usrbincc
Almost forgot. .npmignore should be added to .gitignore
13 years, 2 months ago (2013-03-25 21:09:49 UTC) #3
arv
On 2013/03/25 21:09:49, usrbincc wrote: > Almost forgot. .npmignore should be added to .gitignore Don't ...
13 years, 2 months ago (2013-03-25 22:00:22 UTC) #4
arv
On 2013/03/25 21:06:16, usrbincc wrote: > After reading that .npmignore uses the same format as ...
13 years, 2 months ago (2013-03-25 22:01:20 UTC) #5
arv
I knew it was good to have you review this.
13 years, 2 months ago (2013-03-25 22:01:41 UTC) #6
usrbincc
13 years, 2 months ago (2013-03-25 22:26:31 UTC) #7
> Don't you mean the other way around? .gitignore should be ignored by
> .npmignore.

I meant it the way I said it, but I don't really know what I was
thinking when I said it. It's *supposed* to get committed, after all.
Doh.

(.git|.npm)Ignore my previous comment.

----

I forgot to include README, COPYING, and AUTHORS. Possibly some other
things. Definitely double check.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b