Issue 7530043: code review 7530043: cmd/cgo: split cgo_export into cgo_export_static and cg...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7530043: code review 7530043: cmd/cgo: split cgo_export into cgo_export_static and cg... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by rsc

Modified:
12 years, 3 months ago

Reviewers:

CC:
golang-dev, remyoudompheng, iant

Visibility:
Public.

Description

cmd/cgo: split cgo_export into cgo_export_static and cgo_export_dynamic Also emit cgo_ldflag pragmas.

Patch Set 2 : diff -r ef6c59f8f54f https://code.google.com/p/go/ #

Patch Set 3 : diff -r 76aa0f678f52 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r bc4ace1381c9 https://code.google.com/p/go/ #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -23 lines)			Patch
M	src/cmd/cc/dpchk.c	View	1	2 chunks	+18 lines, -4 lines	0 comments	Download
M	src/cmd/cgo/doc.go	View	1 2 3	2 chunks	+11 lines, -3 lines	0 comments	Download
M	src/cmd/cgo/gcc.go	View	1	1 chunk	+1 line, -5 lines	0 comments	Download
M	src/cmd/cgo/main.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/cmd/cgo/out.go	View	1	3 chunks	+9 lines, -2 lines	0 comments	Download
M	src/cmd/ld/go.c	View	1	3 chunks	+22 lines, -7 lines	0 comments	Download
M	src/cmd/ld/lib.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 3 months ago (2013-03-06 20:03:46 UTC) #1

rsc

Yes, all the cgo work is toward fixing issue 4069, but I haven't been using ...

12 years, 3 months ago (2013-03-06 20:29:49 UTC) #3

iant

LGTM https://codereview.appspot.com/7530043/diff/5001/src/cmd/cgo/doc.go File src/cmd/cgo/doc.go (right): https://codereview.appspot.com/7530043/diff/5001/src/cmd/cgo/doc.go#newcode516 src/cmd/cgo/doc.go:516: For compatibility with current versions of SWIG, I ...

12 years, 3 months ago (2013-03-06 21:36:01 UTC) #4

rsc

12 years, 3 months ago (2013-03-06 21:57:18 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=011944857f1f ***

cmd/cgo: split cgo_export into cgo_export_static and cgo_export_dynamic

Also emit cgo_ldflag pragmas.

R=golang-dev, remyoudompheng, iant
CC=golang-dev
https://codereview.appspot.com/7530043

Expand All Messages | Collapse All Messages