Issue 7529049: code review 7529049: runtime: fix build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7529049: code review 7529049: runtime: fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by dvyukov

Modified:
12 years ago

Reviewers:
mikio

CC:
golang-dev

Visibility:
Public.

Description

runtime: fix build

Patch Set 1 #

Patch Set 2 : diff -r 5af2130aec77 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 5af2130aec77 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 5af2130aec77 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/pkg/runtime/netpoll.goc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

12 years ago (2013-03-14 06:59:41 UTC) #1

dvyukov

*** Submitted as https://code.google.com/p/go/source/detail?r=dcb835ff82e0 *** runtime: fix build R=golang-dev CC=golang-dev https://codereview.appspot.com/7529049

12 years ago (2013-03-14 07:00:12 UTC) #2

dvyukov

12 years ago (2013-03-14 07:18:03 UTC) #4

good flight!
the build seems to be fixed

On Thu, Mar 14, 2013 at 11:08 AM,  <mikioh.mikioh@gmail.com> wrote:
> LGTM
>
> at boarding bridge, phew.
>
> https://codereview.appspot.com/7529049/

Expand All Messages | Collapse All Messages