Issue 7529045: Fix BadStatusLine issue.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7529045: Fix BadStatusLine issue. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by jcgregorio_google

Modified:
11 years, 1 month ago

Reviewers:
dhermes

CC:
httplib2-dev_googlegroups.com

Visibility:
Public.

More Reviews

Patch Set 3 : 80 #

Total comments: 2

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -3 lines)			Patch
M	python2/httplib2/__init__.py	View		2 chunks	+17 lines, -1 line	0 comments	Download
M	python2/httplib2test.py	View	1 2	2 chunks	+41 lines, -0 lines	0 comments	Download
M	python3/httplib2/__init__.py	View		2 chunks	+17 lines, -1 line	0 comments	Download
M	python3/httplib2test.py	View	1	3 chunks	+45 lines, -1 line	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dhermes

LGTM https://codereview.appspot.com/7529045/diff/3001/python3/httplib2test.py File python3/httplib2test.py (right): https://codereview.appspot.com/7529045/diff/3001/python3/httplib2test.py#newcode201 python3/httplib2test.py:201: self.assertEqual(content, b"the body") Only one line between class/instance ...

11 years, 1 month ago (2013-03-11 16:44:50 UTC) #2

jcgregorio_google

11 years, 1 month ago (2013-03-26 14:15:52 UTC) #3

Committed in 261:4adde1593f41

On 2013/03/11 16:44:50, dhermes wrote:
> LGTM
> 
> https://codereview.appspot.com/7529045/diff/3001/python3/httplib2test.py
> File python3/httplib2test.py (right):
> 
>
https://codereview.appspot.com/7529045/diff/3001/python3/httplib2test.py#newc...
> python3/httplib2test.py:201: self.assertEqual(content, b"the body")
> Only one line between class/instance methods.
> 
>
https://codereview.appspot.com/7529045/diff/3001/python3/httplib2test.py#newc...
> python3/httplib2test.py:216: def testGetUnknownServer(self):
> Ditto.

Expand All Messages | Collapse All Messages