Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(60)

Issue 7529045: Fix BadStatusLine issue. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by jcgregorio_google
Modified:
11 years, 9 months ago
Reviewers:
dhermes
CC:
httplib2-dev_googlegroups.com
Visibility:
Public.

Description

Fix BadStatusLine issue.

Patch Set 1 #

Patch Set 2 : 80 chars #

Patch Set 3 : 80 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -3 lines) Patch
M python2/httplib2/__init__.py View 2 chunks +17 lines, -1 line 0 comments Download
M python2/httplib2test.py View 1 2 2 chunks +41 lines, -0 lines 0 comments Download
M python3/httplib2/__init__.py View 2 chunks +17 lines, -1 line 0 comments Download
M python3/httplib2test.py View 1 3 chunks +45 lines, -1 line 2 comments Download

Messages

Total messages: 3
jcgregorio_google
11 years, 9 months ago (2013-03-08 18:08:07 UTC) #1
dhermes
LGTM https://codereview.appspot.com/7529045/diff/3001/python3/httplib2test.py File python3/httplib2test.py (right): https://codereview.appspot.com/7529045/diff/3001/python3/httplib2test.py#newcode201 python3/httplib2test.py:201: self.assertEqual(content, b"the body") Only one line between class/instance ...
11 years, 9 months ago (2013-03-11 16:44:50 UTC) #2
jcgregorio_google
11 years, 9 months ago (2013-03-26 14:15:52 UTC) #3
Committed in 261:4adde1593f41

On 2013/03/11 16:44:50, dhermes wrote:
> LGTM
> 
> https://codereview.appspot.com/7529045/diff/3001/python3/httplib2test.py
> File python3/httplib2test.py (right):
> 
>
https://codereview.appspot.com/7529045/diff/3001/python3/httplib2test.py#newc...
> python3/httplib2test.py:201: self.assertEqual(content, b"the body")
> Only one line between class/instance methods.
> 
>
https://codereview.appspot.com/7529045/diff/3001/python3/httplib2test.py#newc...
> python3/httplib2test.py:216: def testGetUnknownServer(self):
> Ditto.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b