Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1069)

Issue 7527043: Correct url for openstack info on metadata service

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 10 months ago by gz
Modified:
6 years, 10 months ago
Reviewers:
jameinel, mp+152038
Visibility:
Public.

Description

Correct url for openstack info on metadata service The location on the metadata service we were using to retrieve the openstack specific json file was misnamed and lacked the 'openstack' path component, which was causing the legacy id to be used in all cases. That results in a suicidal state server, which also hints we need to worry more about the other cases when we may run into non-canonical server ids. https://code.launchpad.net/~gz/juju-core/fix_openstack_metadata_location/+merge/152038 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Correct url for openstack info on metadata service #

Patch Set 3 : Correct url for openstack info on metadata service #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M environs/openstack/provider.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M environs/openstack/testdata/openstack/2012-08-10/meta_data.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5
gz
Please take a look.
6 years, 10 months ago (2013-03-06 19:19:12 UTC) #1
dfc
https://codereview.appspot.com/7527043/diff/1/environs/openstack/provider.go File environs/openstack/provider.go (right): https://codereview.appspot.com/7527043/diff/1/environs/openstack/provider.go#newcode189 environs/openstack/provider.go:189: uri := fmt.Sprintf("%s/openstack/%s", metadataHost, metadataJSON) shouldn't metadataJSON be "openstack/2012-08-10/meta-data.json"
6 years, 10 months ago (2013-03-06 19:24:55 UTC) #2
gz
Please take a look.
6 years, 10 months ago (2013-03-06 19:29:23 UTC) #3
jameinel
LGTM, and tested working.
6 years, 10 months ago (2013-03-06 19:34:09 UTC) #4
gz
6 years, 10 months ago (2013-03-06 19:46:16 UTC) #5
*** Submitted:

Correct url for openstack info on metadata service

The location on the metadata service we were using to retrieve the openstack
specific json file was misnamed and lacked the 'openstack' path component,
which was causing the legacy id to be used in all cases. That results in a
suicidal state server, which also hints we need to worry more about the
other cases when we may run into non-canonical server ids.

R=dfc, jameinel
CC=
https://codereview.appspot.com/7527043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b