Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(488)

Issue 7523043: code review 7523043: lib9: add mktempdir, removeall, runprog (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by rsc
Modified:
12 years, 1 month ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

lib9: add mktempdir, removeall, runprog

Patch Set 1 #

Patch Set 2 : diff -r d4e1ec84876c https://go.googlecode.com/hg #

Patch Set 3 : diff -r 49d0e24aec10 https://code.google.com/p/go/ #

Patch Set 4 : diff -r ef6c59f8f54f https://code.google.com/p/go/ #

Patch Set 5 : diff -r d8a691500f6f https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+396 lines, -0 lines) Patch
M include/libc.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/cmd/dist/windows.c View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A src/lib9/run_plan9.c View 1 1 chunk +38 lines, -0 lines 0 comments Download
A src/lib9/run_unix.c View 1 1 chunk +43 lines, -0 lines 0 comments Download
A src/lib9/run_windows.c View 1 2 1 chunk +83 lines, -0 lines 0 comments Download
A src/lib9/tempdir_plan9.c View 1 1 chunk +54 lines, -0 lines 0 comments Download
A src/lib9/tempdir_unix.c View 1 1 chunk +52 lines, -0 lines 0 comments Download
A src/lib9/tempdir_windows.c View 1 2 1 chunk +112 lines, -0 lines 0 comments Download
A src/lib9/win.h View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
12 years, 1 month ago (2013-03-06 19:44:25 UTC) #1
bradfitz
why? On Wed, Mar 6, 2013 at 11:44 AM, <rsc@golang.org> wrote: > Reviewers: golang-dev1, > ...
12 years, 1 month ago (2013-03-06 19:45:35 UTC) #2
bradfitz
LGTM Can't really vouch for windows. On Wed, Mar 6, 2013 at 11:44 AM, <rsc@golang.org> ...
12 years, 1 month ago (2013-03-06 20:37:00 UTC) #3
rsc
I tested that it builds on Windows. It probably doesn't work, but I'm not ready ...
12 years, 1 month ago (2013-03-06 20:48:04 UTC) #4
rsc
12 years, 1 month ago (2013-03-06 20:48:33 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=405904c00584 ***

lib9: add mktempdir, removeall, runprog

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7523043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b