Issue 7522044: [TRIVIAL] Properly build ws url

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7522044: [TRIVIAL] Properly build ws url

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by bcsaller

Modified:
11 years, 1 month ago

Reviewers:
mp+152050, jeff.pihach, rharding

Visibility:
Public.

Description

[TRIVIAL] Properly build ws url Location object omits port when its a default. In such case don't include it in the assembled URL. https://code.launchpad.net/~bcsaller/juju-gui/wsurl-fix/+merge/152050 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Properly build ws url #

Patch Set 3 : Properly build ws url #

Patch Set 4 : [TRIVIAL] Properly build ws url #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
		[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
		app/index.html	View	1 2 3	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

bcsaller

11 years, 1 month ago (2013-03-06 20:36:44 UTC) #7

*** Submitted:

[TRIVIAL] Properly build ws url

Location object omits port when its a default. In such case
don't include it in the assembled URL.

R=jeff.pihach
CC=
https://codereview.appspot.com/7522044

Expand All Messages | Collapse All Messages