Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1235)

Issue 7519043: state/api/params: new package

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 10 months ago by rog
Modified:
6 years, 10 months ago
Reviewers:
bac, mp+152025, matthew.scott
Visibility:
Public.

Description

state/api/params: new package This enables us to break the cycle: launchpad.net/juju-core/juju launchpad.net/juju-core/environs launchpad.net/juju-core/state/api launchpad.net/juju-core/state/statecmd launchpad.net/juju-core/juju https://code.launchpad.net/~rogpeppe/juju-core/238-cmdparams-package/+merge/152025 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state/api/params: new package #

Total comments: 2

Patch Set 3 : state/api/params: new package #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -138 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/expose.go View 2 chunks +2 lines, -1 line 0 comments Download
M cmd/juju/get.go View 2 chunks +2 lines, -1 line 0 comments Download
M cmd/juju/set.go View 2 chunks +3 lines, -2 lines 0 comments Download
M cmd/juju/unexpose.go View 2 chunks +2 lines, -1 line 0 comments Download
M state/api/apiclient.go View 13 chunks +14 lines, -48 lines 0 comments Download
A state/api/params/params.go View 1 2 1 chunk +72 lines, -0 lines 0 comments Download
M state/apiserver/api_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M state/apiserver/apiserver.go View 6 chunks +18 lines, -17 lines 0 comments Download
M state/statecmd/config.go View 1 chunk +3 lines, -17 lines 0 comments Download
M state/statecmd/config_test.go View 12 chunks +19 lines, -18 lines 0 comments Download
M state/statecmd/expose.go View 1 chunk +2 lines, -6 lines 0 comments Download
M state/statecmd/expose_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M state/statecmd/get.go View 1 chunk +6 lines, -17 lines 0 comments Download
M state/statecmd/unexpose.go View 1 chunk +3 lines, -6 lines 0 comments Download
M state/statecmd/unexpose_test.go View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4
rog
Please take a look.
6 years, 10 months ago (2013-03-06 18:22:20 UTC) #1
bac
LGTM Roger. I have not tested it with my branch yet to ensure the import ...
6 years, 10 months ago (2013-03-06 18:46:44 UTC) #2
matthew.scott
LGTM, fixes import loops for my branch. Thanks!
6 years, 10 months ago (2013-03-06 18:50:42 UTC) #3
rog
6 years, 10 months ago (2013-03-06 19:16:22 UTC) #4
*** Submitted:

state/api/params: new package

This enables us to break the cycle:
	launchpad.net/juju-core/juju
	launchpad.net/juju-core/environs
	launchpad.net/juju-core/state/api
	launchpad.net/juju-core/state/statecmd
	launchpad.net/juju-core/juju

R=bac, matthew.scott
CC=
https://codereview.appspot.com/7519043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b