Fix invalid path escaping in GYP files.

Fix invalid path escaping in GYP files.

This seems to fix the remaining issues to build with Ninja.
Unfortunately, the unittests built with Ninja fail because some path
need to be updated.

R=chrisha@chromium.org, sebmarchand@chromium.org

Committed: https://code.google.com/p/sawbuck/source/detail?r=2077

[etienneb, 2014-03-13 14:16:26]

PTAL.

Note: The .lib files doesn't have the same name.
This may affect some sebmarchand@ script.

It won't break the build because we are on MSVS but some paths may need to be
updated.

[chrisha, 2014-03-13 14:20:53]

A handful of comments...

https://codereview.appspot.com/75190043/diff/40001/syzygy/build/all.gyp
File syzygy/build/all.gyp (right):

https://codereview.appspot.com/75190043/diff/40001/syzygy/build/all.gyp#newco...
syzygy/build/all.gyp:144: ['"<(GENERATOR)"=="ninja"', {
Deal with msvs_ninja as well while we're at it?

https://codereview.appspot.com/75190043/diff/40001/syzygy/test_data/test_data...
File syzygy/test_data/test_data.gyp (right):

https://codereview.appspot.com/75190043/diff/40001/syzygy/test_data/test_data...
syzygy/test_data/test_data.gyp:52: ['"<(GENERATOR)"=="ninja"', {
There's also msvs_ninja to deal with. Try generating with that to see where it's
output goes?

https://codereview.appspot.com/75190043/diff/40001/syzygy/test_data/test_data...
syzygy/test_data/test_data.gyp:55: # intermediate/auxiliary output files.
The comment only needs to be appear once, before the conditions.

[Sébastien Marchand, 2014-03-13 15:10:57]

Nice. There's also some change that need to be made to all.gyp if you change the
name of some of the artifacts (e.g. syzyasan_rtl.lib), as well as in
README.TXT.template.

Try to do an official build on your machine (build the target binaries_zip) to
double check that you didn't break anything :)

https://codereview.appspot.com/75190043/diff/40001/syzygy/build/all.gyp
File syzygy/build/all.gyp (right):

https://codereview.appspot.com/75190043/diff/40001/syzygy/build/all.gyp#newco...
syzygy/build/all.gyp:148: 'syzyasan_rtl_lib':
'<(PRODUCT_DIR)/lib/syzyasan_rtl.lib',
The name need to be consistent (independently of the toolchain) as this is
something that we ship.

You can use the ImportLibrary attribute:
http://msdn.microsoft.com/en-us/library/microsoft.visualstudio.vcprojectengin...

[etienneb, 2014-03-13 19:39:16]

PTAnL.

I must roll the deps again.
The last gyp CL, which breaks msvs linking step, got reverted.

https://codereview.appspot.com/75190043/diff/40001/syzygy/build/all.gyp
File syzygy/build/all.gyp (right):

https://codereview.appspot.com/75190043/diff/40001/syzygy/build/all.gyp#newco...
syzygy/build/all.gyp:144: ['"<(GENERATOR)"=="ninja"', {
On 2014/03/13 14:20:54, chrisha wrote:
> Deal with msvs_ninja as well while we're at it?

Done.

https://codereview.appspot.com/75190043/diff/40001/syzygy/build/all.gyp#newco...
syzygy/build/all.gyp:148: 'syzyasan_rtl_lib':
'<(PRODUCT_DIR)/lib/syzyasan_rtl.lib',
I agree.
I propose to fix the "official" build and the build-bot as a second phase.

I would like to fix all unittests and ninja for a developper point of view
first.

On 2014/03/13 15:10:57, Sébastien Marchand wrote:
> The name need to be consistent (independently of the toolchain) as this is
> something that we ship.
> 
> You can use the ImportLibrary attribute:
>
http://msdn.microsoft.com/en-us/library/microsoft.visualstudio.vcprojectengin...

https://codereview.appspot.com/75190043/diff/40001/syzygy/test_data/test_data...
File syzygy/test_data/test_data.gyp (right):

https://codereview.appspot.com/75190043/diff/40001/syzygy/test_data/test_data...
syzygy/test_data/test_data.gyp:52: ['"<(GENERATOR)"=="ninja"', {
On 2014/03/13 14:20:54, chrisha wrote:
> There's also msvs_ninja to deal with. Try generating with that to see where
it's
> output goes?

Done.

https://codereview.appspot.com/75190043/diff/40001/syzygy/test_data/test_data...
syzygy/test_data/test_data.gyp:55: # intermediate/auxiliary output files.
On 2014/03/13 14:20:54, chrisha wrote:
> The comment only needs to be appear once, before the conditions.

Done.

[chrisha, 2014-03-13 19:40:07]

lgtm!

[Sébastien Marchand, 2014-03-13 19:53:37]

lgtm

https://codereview.appspot.com/75190043/diff/60001/syzygy/build/all.gyp
File syzygy/build/all.gyp (right):

https://codereview.appspot.com/75190043/diff/60001/syzygy/build/all.gyp#newco...
syzygy/build/all.gyp:146: # for official packaging if SyzyASAN.
indent+4 maybe ?
s/if/of/
s/SyzyASAN/SyzyASan/ ?

[etienneb, 2014-03-13 19:57:55]

done, committing as soon as all the builds are tested.

https://codereview.appspot.com/75190043/diff/60001/syzygy/build/all.gyp
File syzygy/build/all.gyp (right):

https://codereview.appspot.com/75190043/diff/60001/syzygy/build/all.gyp#newco...
syzygy/build/all.gyp:146: # for official packaging if SyzyASAN.
On 2014/03/13 19:53:38, Sébastien Marchand wrote:
> indent+4 maybe ?
> s/if/of/
> s/SyzyASAN/SyzyASan/ ?

Done.

[etienneb, 2014-03-13 20:32:53]

Committed patchset #4 manually as r2077 (presubmit successful).