Issue 7518052: rpc: continue after error reading body

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7518052: rpc: continue after error reading body

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by rog

Modified:
11 years ago

Reviewers:
dimitern, dave, mp+155825

Visibility:
Public.

Description

rpc: continue after error reading body If we get an error reading an rpc message body, it's likely because of a syntax error issue rather than anything fundamental, so we return an error rather than dropping the connection. https://code.launchpad.net/~rogpeppe/juju-core/261-rpc-do-not-abort-on-body-error/+merge/155825 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : rpc: continue after error reading body #

Total comments: 2

Patch Set 3 : rpc: continue after error reading body #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -21 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	rpc/rpc_test.go	View		9 chunks	+47 lines, -20 lines	0 comments	Download
M	rpc/server.go	View	1 2	1 chunk	+24 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dave_cheney.net

LGTM with a request for clarification. https://codereview.appspot.com/7518052/diff/2001/rpc/server.go File rpc/server.go (right): https://codereview.appspot.com/7518052/diff/2001/rpc/server.go#newcode142 rpc/server.go:142: if err == ...

11 years, 1 month ago (2013-03-27 23:18:27 UTC) #3

rog

11 years ago (2013-04-03 13:27:10 UTC) #4

*** Submitted:

rpc: continue after error reading body

If we get an error reading an rpc message body,
it's likely because of a syntax error issue rather
than anything fundamental, so we return
an error rather than dropping the connection.

R=dimitern, dfc
CC=
https://codereview.appspot.com/7518052

https://codereview.appspot.com/7518052/diff/2001/rpc/server.go
File rpc/server.go (right):

https://codereview.appspot.com/7518052/diff/2001/rpc/server.go#newcode142
rpc/server.go:142: if err == io.EOF || err == io.ErrUnexpectedEOF {
On 2013/03/27 23:18:27, dfc wrote:
> io.EOF is expected, but could you give a few words why we expect the
unexpected
> io.ErrUnexpectedEOF ?

Done.

Expand All Messages | Collapse All Messages