Issue 75140045: code review 75140045: net: fix TCP keepalive on dragonfly

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 75140045: code review 75140045: net: fix TCP keepalive on dragonfly (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by mikio

Modified:
11 years, 3 months ago

Reviewers:
jsing

CC:
jsing, golang-codereviews

Visibility:
Public.

Description

net: fix TCP keepalive on dragonfly Fixes issue 7528.

Patch Set 1 #

Patch Set 2 : diff -r 017d82d5ef30 https://code.google.com/p/go #

Patch Set 3 : diff -r 017d82d5ef30 https://code.google.com/p/go #

Patch Set 4 : diff -r 017d82d5ef30 https://code.google.com/p/go #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -8 lines)			Patch
	M	src/pkg/net/tcpsockopt_dragonfly.go	View	1	2 chunks	+5 lines, -7 lines	0 comments	Download
	M	src/pkg/net/tcpsockopt_unix.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mikio

Hello jsing@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 3 months ago (2014-03-13 05:33:29 UTC) #1

mikio

*** Submitted as https://code.google.com/p/go/source/detail?r=d115d6b9aaa2 *** net: fix TCP keepalive on dragonfly Fixes issue 7528. LGTM=jsing ...

11 years, 3 months ago (2014-03-13 05:45:49 UTC) #3

mikio

11 years, 3 months ago (2014-03-13 05:54:13 UTC) #4

On Thu, Mar 13, 2014 at 2:41 PM,  <jsing@google.com> wrote:

> Ouch, thanks. The wonderful thing about standards...

We proved that we're not good enough to be able to land our spacecraft
safely, sigh.

Expand All Messages | Collapse All Messages