Issue 75140043: code review 75140043: go.tools/cmd/vet: don't check for shadowing of blank id...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 75140043: code review 75140043: go.tools/cmd/vet: don't check for shadowing of blank id... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by r

Modified:
11 years, 1 month ago

Reviewers:
gri

CC:
gri, golang-codereviews

Visibility:
Public.

Description

go.tools/cmd/vet: don't check for shadowing of blank identifier It's pointless. Also this fixes a crash, because the blank identifier no longer appears as a defined object after CL 74190043 so we were getting nil pointer violations. Even better, we get to re-enable a disabled test.

Patch Set 1 #

Patch Set 2 : diff -r 41e943a29d80 https://code.google.com/p/go.tools #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	cmd/vet/shadow.go	View		2 chunks	+4 lines, -3 lines	0 comments	Download
	M	cmd/vet/testdata/shadow.go	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello gri (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

11 years, 1 month ago (2014-03-12 23:25:27 UTC) #1

11 years, 1 month ago (2014-03-12 23:28:06 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=99e226f19fba&repo=tools ***

go.tools/cmd/vet: don't check for shadowing of blank identifier
It's pointless.
Also this fixes a crash, because the blank identifier no longer appears as a
defined object after CL 74190043 so we were getting nil pointer violations.
Even better, we get to re-enable a disabled test.

LGTM=gri
R=gri
CC=golang-codereviews
https://codereview.appspot.com/75140043

Expand All Messages | Collapse All Messages