code review 7513045: net: more refactoring in preparation for runtime integr...

net: more refactoring in preparation for runtime integrated pollster
Move pollServer from fd_unix.go to fd_poll_unix.go.
Add pollServerInit(*NetFD) to allow custom initialization.
Add pollServer.Close(*NetFD) to allow custom finalization.
Move setDeadline() to fd_poll_unix.go to allow custom handling of deadlines.
Move newPollServer() to fd_poll_unix.go to allow custom initialization.
No logical code changes.
The next step will be to turn off fd_poll_unix.go for some platform
(I have changes for darwin/linux) and redirect it into runtime. See:
https://codereview.appspot.com/7569043/diff/2001/src/pkg/net/fd_poll_runtime.go

[dvyukov, 2013-03-07 13:44:59]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[bradfitz, 2013-03-07 16:35:30]

LGTM

On Thu, Mar 7, 2013 at 5:44 AM, <dvyukov@google.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
>
https://dvyukov%40google.com@**code.google.com/p/go/<http://40google.com@code...
>
>
> Description:
> net: more refactoring in preparation for runtime integrated pollster
> Move pollServer from fd_unix.go to fd_poll_unix.go.
> Add pollServerInit(*NetFD) to allow custom initialization.
> Add pollServer.Close(*NetFD) to allow custom finalization.
> Move setDeadline() to fd_poll_unix.go to allow custom handling of
> deadlines.
> Move newPollServer() to fd_poll_unix.go to allow custom initialization.
> No logical code changes.
> The next step will be to turn off fd_poll_unix.go for some platform
> (I have changes for darwin/linux) and redirect it into runtime. See:
> https://codereview.appspot.**com/7569043/diff/2001/src/pkg/**
>
net/fd_poll_runtime.go<https://codereview.appspot.com/7569043/diff/2001/src/pkg/net/fd_poll_runtime.go>
>
> Please review this at
https://codereview.appspot.**com/7513045/<https://codereview.appspot.com/7513...
>
> Affected files:
>   A src/pkg/net/fd_poll_unix.go
>   M src/pkg/net/fd_unix.go
>   R src/pkg/net/newpollserver_**unix.go
>   M src/pkg/net/sock_posix.go
>   M src/pkg/net/sockopt_posix.go
>   M src/pkg/net/sockopt_windows.go
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[dvyukov, 2013-03-07 17:45:09]

*** Submitted as https://code.google.com/p/go/source/detail?r=220ad1fe57ad ***

net: more refactoring in preparation for runtime integrated pollster
Move pollServer from fd_unix.go to fd_poll_unix.go.
Add pollServerInit(*NetFD) to allow custom initialization.
Add pollServer.Close(*NetFD) to allow custom finalization.
Move setDeadline() to fd_poll_unix.go to allow custom handling of deadlines.
Move newPollServer() to fd_poll_unix.go to allow custom initialization.
No logical code changes.
The next step will be to turn off fd_poll_unix.go for some platform
(I have changes for darwin/linux) and redirect it into runtime. See:
https://codereview.appspot.com/7569043/diff/2001/src/pkg/net/fd_poll_runtime.go

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7513045

[mikio, 2013-03-08 00:27:02]

https://codereview.appspot.com/7513045/diff/16001/src/pkg/net/newpollserver_u...
File src/pkg/net/newpollserver_unix.go (left):

https://codereview.appspot.com/7513045/diff/16001/src/pkg/net/newpollserver_u...
src/pkg/net/newpollserver_unix.go:14: func newPollServer() (s *pollServer, err
error) {
IIRC, gofrontend requires separated newPollServer.

https://code.google.com/p/gofrontend/source/browse/libgo/go/net/newpollserver...

[iant, 2013-03-08 01:20:00]

https://codereview.appspot.com/7513045/diff/16001/src/pkg/net/newpollserver_u...
File src/pkg/net/newpollserver_unix.go (left):

https://codereview.appspot.com/7513045/diff/16001/src/pkg/net/newpollserver_u...
src/pkg/net/newpollserver_unix.go:14: func newPollServer() (s *pollServer, err
error) {
On 2013/03/08 00:27:02, mikio wrote:
> IIRC, gofrontend requires separated newPollServer.

Yes, because RTEMS doesn't have pipe.  But this all might change in the new
world, I don't know.