Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(42)

Issue 7510047: code review 7510047: net: fix documentation for UnixAddr (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by mikio
Modified:
12 years, 9 months ago
Reviewers:
CC:
golang-dev, dave_cheney.net, rsc, bradfitz
Visibility:
Public.

Description

net: fix documentation for UnixAddr Also simplifies ResolveUnixAddr.

Patch Set 1 #

Patch Set 2 : diff -r 9ca85035f95a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9ca85035f95a https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 9ca85035f95a https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 5 : diff -r 49782ab10063 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M src/pkg/net/unixsock.go View 1 2 3 4 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 9 months ago (2013-03-22 12:12:34 UTC) #1
dave_cheney.net
LGTM. Thank you. Please try to hold the changes which do not address bugs targeted ...
12 years, 9 months ago (2013-03-22 12:24:55 UTC) #2
rsc
LGTM It's okay to submit this, since it updates the docs.
12 years, 9 months ago (2013-03-22 14:27:24 UTC) #3
bradfitz
https://codereview.appspot.com/7510047/diff/1003/src/pkg/net/unixsock.go File src/pkg/net/unixsock.go (right): https://codereview.appspot.com/7510047/diff/1003/src/pkg/net/unixsock.go#newcode44 src/pkg/net/unixsock.go:44: return &UnixAddr{Name: addr, Net: net}, nil just move this ...
12 years, 9 months ago (2013-03-22 14:53:50 UTC) #4
mikio
12 years, 9 months ago (2013-03-22 22:40:06 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=7f98f88548ff ***

net: fix documentation for UnixAddr

Also simplifies ResolveUnixAddr.

R=golang-dev, dave, rsc, bradfitz
CC=golang-dev
https://codereview.appspot.com/7510047

https://codereview.appspot.com/7510047/diff/1003/src/pkg/net/unixsock.go
File src/pkg/net/unixsock.go (right):

https://codereview.appspot.com/7510047/diff/1003/src/pkg/net/unixsock.go#newc...
src/pkg/net/unixsock.go:44: return &UnixAddr{Name: addr, Net: net}, nil
On 2013/03/22 14:53:50, bradfitz wrote:
> just move this return up inside its case while you're here.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b