Issue 7510047: code review 7510047: net: fix documentation for UnixAddr

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7510047: code review 7510047: net: fix documentation for UnixAddr (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by mikio

Modified:
12 years, 9 months ago

Reviewers:

CC:
golang-dev, dave_cheney.net, rsc, bradfitz

Visibility:
Public.

Description

net: fix documentation for UnixAddr Also simplifies ResolveUnixAddr.

Patch Set 2 : diff -r 9ca85035f95a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9ca85035f95a https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 9ca85035f95a https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 5 : diff -r 49782ab10063 https://go.googlecode.com/hg/ #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	src/pkg/net/unixsock.go	View	1 2 3 4	2 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 9 months ago (2013-03-22 12:12:34 UTC) #1

dave_cheney.net

LGTM. Thank you. Please try to hold the changes which do not address bugs targeted ...

12 years, 9 months ago (2013-03-22 12:24:55 UTC) #2

bradfitz

https://codereview.appspot.com/7510047/diff/1003/src/pkg/net/unixsock.go File src/pkg/net/unixsock.go (right): https://codereview.appspot.com/7510047/diff/1003/src/pkg/net/unixsock.go#newcode44 src/pkg/net/unixsock.go:44: return &UnixAddr{Name: addr, Net: net}, nil just move this ...

12 years, 9 months ago (2013-03-22 14:53:50 UTC) #4

mikio

12 years, 9 months ago (2013-03-22 22:40:06 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=7f98f88548ff ***

net: fix documentation for UnixAddr

Also simplifies ResolveUnixAddr.

R=golang-dev, dave, rsc, bradfitz
CC=golang-dev
https://codereview.appspot.com/7510047

https://codereview.appspot.com/7510047/diff/1003/src/pkg/net/unixsock.go
File src/pkg/net/unixsock.go (right):

https://codereview.appspot.com/7510047/diff/1003/src/pkg/net/unixsock.go#newc...
src/pkg/net/unixsock.go:44: return &UnixAddr{Name: addr, Net: net}, nil
On 2013/03/22 14:53:50, bradfitz wrote:
> just move this return up inside its case while you're here.

Done.

Expand All Messages | Collapse All Messages