Issue 7504047: code review 7504047: cmd/gc: implement more cases in racewalk.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7504047: code review 7504047: cmd/gc: implement more cases in racewalk. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by remyoudompheng

Modified:
12 years ago

Reviewers:

CC:
dvyukov, golang-dev

Visibility:
Public.

Description

cmd/gc: implement more cases in racewalk. Add missing CLOSUREVAR in switch. Mark MAKE, string conversion nodes as impossible. Control statements do not need instrumentation. Instrument COM and LROT nodes. Instrument map length. Update issue 4228

Patch Set 1 #

Patch Set 2 : diff -r 85b1cc5d35dd https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 85b1cc5d35dd https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 85b1cc5d35dd https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 85b1cc5d35dd https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r c246dbf446db https://go.googlecode.com/hg/ #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+162 lines, -38 lines)			Patch
M	src/cmd/gc/racewalk.c	View	1 2 3 4	6 chunks	+31 lines, -34 lines	0 comments	Download
M	src/pkg/runtime/race/testdata/map_test.go	View	1 2 3 4	2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/race/testdata/mop_test.go	View	1 2 3	1 chunk	+96 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/race/testdata/regression_test.go	View	1 2 3 4	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/race/testdata/slice_test.go	View	1 2 3 4	1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

remyoudompheng

Hello dvyukov@google.com, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years ago (2013-03-20 22:45:28 UTC) #1

remyoudompheng

Hello dvyukov@google.com, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

12 years ago (2013-03-20 23:33:15 UTC) #2

remyoudompheng

12 years ago (2013-03-21 07:53:59 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=ee1b8339ab04 ***

cmd/gc: implement more cases in racewalk.

Add missing CLOSUREVAR in switch.
Mark MAKE, string conversion nodes as impossible.
Control statements do not need instrumentation.
Instrument COM and LROT nodes.
Instrument map length.

Update issue 4228

R=dvyukov, golang-dev
CC=golang-dev
https://codereview.appspot.com/7504047

Expand All Messages | Collapse All Messages